Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance Model Creation Crashes on Modal Properties on Threads included in a Thread Group #1616

Closed
dblouin opened this issue Oct 28, 2018 · 2 comments
Assignees
Milestone

Comments

@dblouin
Copy link
Contributor

@dblouin dblouin commented Oct 28, 2018

There is an error when creating the instance model of the system implementation in
Main_System.zip

the attached AADL file.
The error is:
image

An instance model is still created but the Compute_Execution_Time properties are not set on the thread subcomponent.

OSATE version: 2.3.4.vfinal -- Build id: 2018-07-11

Windows OS

@lwrage
Copy link
Contributor

@lwrage lwrage commented Oct 29, 2018

@dblouin You can embed (short) aadl code directly in an issue. That makes it easier for us to cut and paste.

package Main_System
public
	
	system main
	end main;
	
	system implementation main.impl
		subcomponents
			proc: process proc1.impl;
	end main.impl;
	
	process proc1
		modes
			LO: initial mode;
			HI: mode;
	end proc1;
	
	process implementation proc1.impl
		subcomponents
			group1: thread group group1.impl in modes (LO=>LO,HI=>HI);
	end proc1.impl;
	
	thread group group1
		requires modes
			LO: initial mode;
			HI: mode;
	end group1;
	
	thread group implementation group1.impl
		subcomponents
			thread1: thread thread1.impl {
				Compute_Execution_Time => 200 ms .. 200 ms in modes (LO), 300 ms .. 300 ms in modes (HI);
			} in modes (LO=>LO, HI=>HI);
	end group1.impl;
	
	thread thread1
		requires modes
			LO: initial mode;
			HI: mode;
	end thread1;

	thread implementation thread1.impl
	end thread1.impl;
	
end Main_System;
@lwrage lwrage added the next label Oct 29, 2018
@lwrage lwrage self-assigned this Oct 29, 2018
@lwrage lwrage added this to the 2.4 milestone Oct 29, 2018
@lwrage
Copy link
Contributor

@lwrage lwrage commented Oct 29, 2018

The problem is that the model has more than one level of requires modes. This is currently not supported in the instantiation. The generated SOMs in the example contain only two mode references instead of three. The mode references to the thread modes are missing.

lwrage added a commit that referenced this issue Dec 2, 2018
@ghost ghost added in progress and removed next labels Dec 2, 2018
@ghost ghost added review and removed in progress labels Dec 2, 2018
@lwrage lwrage closed this in #1656 Dec 5, 2018
@ghost ghost removed the review label Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants