Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
AADL Navigator: New AADL package is not inserted in correct order #1622
Creating a new AADL package inserts it as the first element in the project.
Expected and Current Behavior
The common navigator framework tries to insert the new package in the correct location but our sorters seem to be wrong. We currently refresh the navigator (see #1608) to force sorting but this is not the correct solution.
Oct 31, 2018
(@philip-alldredge FYI) The real issue is that
On a related note. What is the policy for removing deprecated functionality? Is there a recommended time limit? That label provider is used for legacy diagrams which use UUIDs as the file names. Once such a diagram is opened, it is converted and renamed. At some point it will be removed. Do we have a best practice/recommendation for how many versions to wait before removing such functionality?
@lwrage Yes, it does convert UUID file names as long as they have the .aadl_diagram extension. It doesn't appear that innerLabelProvider is ever used. How the GE actually determines the name based on the UUID is in the DefaultDiagramService. If the filename isn't a UUID then it just returns the filename.
According to the release notes version 2.2.3 (August 21th, 2017) was when stopped using UUIDs for new diagrams. The file format changed and the user is prompted to rename if opening older diagrams.