Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probability computation for fault trees has rounding error due to use of Double #1649

Closed
reteprelief opened this issue Nov 26, 2018 · 1 comment
Closed
Assignees
Milestone

Comments

@reteprelief
Copy link
Contributor

@reteprelief reteprelief commented Nov 26, 2018

We should use BigDecimal to deal with rounding errors.
See #1643 as related issue.

@reteprelief
Copy link
Contributor Author

@reteprelief reteprelief commented Nov 27, 2018

See #1651 as an issue to be addressed to fully satisfy the ability to calculate the occurrence probability correctly. Currently the property does not return the exact user supplied value, thus, the BigDecimal based computation still produces imprecise values - at least the computation does not introduce additional precision error.

@lwrage lwrage closed this in #1650 Jan 25, 2019
@ghost ghost removed the review label Jan 25, 2019
@lwrage lwrage added this to the 2.4.0 milestone Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants