Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Wrong feature group type validation #1671
Suppose I have the feature groups
Now I want to declare an inverse feature group of
But this is complete nonsense because because now
This isn't simply an issue of counting refined features. The validator currently looks at the owned features and the inverse's owned features. It assumes that diamond inheritance is happening, but fails when there is no diamond.
In the following case, IG2 doesn't extend anything. The validator should accept this model, but doesn't.
In another example, IG2 extends a feature group which is not an inverse of FG1. The validator should also accept this model.