Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSATE doesn't reject connection arrays in property associations #1746

Closed
lwrage opened this issue Mar 14, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@lwrage
Copy link
Contributor

commented Mar 14, 2019

Summary

OSATE allows an index when associating properties with a connection even though AADL doesn't have connection arrays.

Expected and Current Behavior

AADL code like the following should be marked with an error in the editor.

Actual_Connection_Binding => (reference (b1[1])) applies to conn1[1];

Steps to Reproduce

Example model:

package pkg
public
    abstract aType
        features
            da: requires data access;
    end aType;

    system s
    end s;

    system implementation s.i
        subcomponents
            d: data[2];
            a: abstract aType[2];
            b1: bus[2];
            
        connections
            conn1: data access d <-> a.da {connection_pattern => ((one_to_one));} ;

        properties
            Actual_Connection_Binding => (reference (b1[1])) applies to conn1[1];
            Actual_Connection_Binding => (reference (b1[2])) applies to conn1[2];
    end s.i;
end pkg;

Environment

  • OSATE Version: 2.4.0
  • Operating System: all
@lwrage

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

Need to check what happens for reference(conn[1]), which should also be rejected.

@lwrage lwrage changed the title OSATE doesn't mark connection arrays with an error OSATE doesn't reject connection arrays in property associations Mar 14, 2019

@lwrage lwrage added this to the 2.5.0 milestone Mar 27, 2019

@lwrage lwrage added next and removed backlog labels Apr 4, 2019

@ghost ghost added in progress and removed next labels Apr 5, 2019

@ghost ghost added review and removed in progress labels Apr 8, 2019

@lwrage lwrage closed this in #1772 Apr 18, 2019

@ghost ghost removed the review label Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.