Error and warning icon decorations in AADL Navigator are not updated #1824

Activity

1. lwrage

   added this to the 2.5.1 milestone on May 30, 2019
2. lwrage

   added

   category:bug

   importance:medium

   on May 30, 2019
3. lwrage

   assigned

   AaronGreenhouse

   on May 30, 2019
4. lwrage

   changed the title [-]Error markers in AADL Navigator are not updated[/-] [+]Error and warning icon decorations in AADL Navigator are not updated[/+] on Jun 3, 2019
5. AaronGreenhouse commented on Jun 19, 2019

   

   AaronGreenhouse

   on Jun 19, 2019

   Contributor

   More actions

   Need to figure out how to trigger a refresh in the common navigator.

   I see an odd thing in the plugin.xml for org.osate.ui. Note the viewerRefresher in the definition of the AadlNavigator:

   	<extension
            point="org.eclipse.ui.navigator.viewer">
   		<viewerContentBinding 
               viewerId="org.osate.ui.navigator.AadlNavigator">
   			<includes>
      				<contentExtension pattern="org.eclipse.ui.navigator.resources.workingSets" />
   				<contentExtension pattern="org.eclipse.ui.navigator.resourceContent" />     	      
   				<contentExtension pattern="org.eclipse.ui.navigator.resources.filters.*"/>
       			<contentExtension pattern="org.osate.ui.navigator.contributedAadl" />
   			    <contentExtension pattern="org.osate.ui.navigator.aadlProjectDependencies" />
       			<contentExtension pattern="org.osate.ui.navigator.aadlFileContent" />
   			    <contentExtension pattern="org.osate.ui.navigator.menuActions" />
   				<contentExtension pattern="org.osate.ui.navigator.AadlNavigatorLinkHelper" />
       <contentExtension
             pattern="org.osate.ui.navigator.viewerRefresher">
       </contentExtension>
   			</includes>
   		</viewerContentBinding>
     		<viewerActionBinding
           	viewerId="org.osate.ui.navigator.AadlNavigator">
        		<includes>
        			<actionExtension pattern="org.eclipse.ui.navigator.resources.*" />
        			<actionExtension pattern="org.osate.ui.navigator.*" />
        		</includes>
   	  </viewerActionBinding>
      </extension>
   

   The problem is there is no mention of this any where else. The name doesn't seem to be bound to anything.
6. AaronGreenhouse commented on Jun 19, 2019

   

   AaronGreenhouse

   on Jun 19, 2019

   Contributor

   More actions

   The Eclipse forum here may be useful, but the original question seems to be imcompletely answered: https://www.eclipse.org/forums/index.php/t/154948/
7. AaronGreenhouse commented on Jun 19, 2019

   

   AaronGreenhouse

   on Jun 19, 2019

   Contributor

   More actions

   These seems more helpful: https://subscription.packtpub.com/book/application_development/9781783287796/1/ch01lvl1sec09/common-navigator
8. AaronGreenhouse commented on Jun 20, 2019

   

   AaronGreenhouse

   on Jun 20, 2019

   Contributor

   More actions

   Made AadlElementContentProvider an IResourceChangeListener. It forces a refresh of the associated viewer when a change event comes through.

   I tried to make the refresh "smart" and only update the viewer when .aadl files are changed, but that didn't work because all the events that came thorugh just indicated that the workspace root had changed. So it didn't make sense to do any fancy checking.
9. lwrage

   added

   core

   on Jul 9, 2019
10. lwrage

    closed this as completedin d9424ccon Jul 9, 2019