Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes cause diagram to appear as dirty #1844

Closed
philip-alldredge opened this issue Jun 14, 2019 · 0 comments
Closed

Notes cause diagram to appear as dirty #1844

philip-alldredge opened this issue Jun 14, 2019 · 0 comments

Comments

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Jun 14, 2019

Diagrams which have notes will appear as dirty after being opened. The reason for this is the dirty check includes an exception for the labels of notes to ensure they are serialized.

The appropriate fix is to modify Note to be immutable and to require updating the BO. Furthermore when updating the BO, the diagram should compare the data of embedded objects and store as a field change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants