Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subprogram access features should be allowed as flow specification ends #1936

Closed
2 tasks done
reteprelief opened this issue Aug 8, 2019 · 4 comments · Fixed by #2849
Closed
2 tasks done

Subprogram access features should be allowed as flow specification ends #1936

reteprelief opened this issue Aug 8, 2019 · 4 comments · Fixed by #2849

Comments

@reteprelief
Copy link
Contributor

reteprelief commented Aug 8, 2019

The standard allows flow end point to be subprogram access.

  • Update meta-model, grammar, name resolution, validation, content assist, etc
  • Update graphical editor

This implements saeaadl/aadlv2.2#39

@lwrage
Copy link
Contributor

lwrage commented Aug 8, 2019

10.1 (N2) only allows "a parameter of a subprogram access feature" but not subprogram access features as such, so OSATE seems to be correct.

@reteprelief
Copy link
Contributor Author

issue#1937 deals with not processing subprogram access . parameter.

For this one I put in an errata for V2.2 (saeaadl/aadlv2.2#39).
The justification for also allowing just a reference to the subprogram access is that the subprogram may not have an in parameter but an out parameter (or vice versa). So in one direction we could not point to a parameter.

@lwrage
Copy link
Contributor

lwrage commented Aug 8, 2019

I'd prefer not to make such changes in OSATE before they have been approved by the committee. Otherwise I'm all for it.

@reteprelief
Copy link
Contributor Author

Ok.
John Hudak is doing some modeling with remote subprogram calls for his IDT work. That's what triggered the sequence of issues. Issues 1937 and 1941 are more relevant at this time.

@lwrage lwrage removed this from the 2.6.0 milestone Aug 12, 2019
@lwrage lwrage changed the title OSATE incorrectly marks flow specs involving subprogram access as error Subprogram access features should be allowed as flow specification ends Aug 15, 2019
@lwrage lwrage assigned lwrage and unassigned reteprelief Jun 29, 2022
@lwrage lwrage added this to the 2.12.0 milestone Jun 29, 2022
lwrage added a commit that referenced this issue Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants