New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using feature-group specific flow paths has instance model errors for the "path not taken". #1984
Comments
So, the generated end to end flow uses feature group sub features
The error
is a "problem" with the source of The error
is a problem with the destination of |
In |
I've been looking at this for a while now trying to understand what the method are really doing, and trying to create a situation where here the That is, I think we never actually want to output an error message from Could use another opinion on this. |
Okay, was finally able to produce some counter examples of sorts. If I take the example above, add a second incoming feature group to
There is an error on the declarative model on The problem here is that the methods |
If you try the same trick but with the outgoing feature group of We sill have an error about a "path not taken" at the start of the end to end flow. (We don't want this.) It seems that
|
Simpler examples that don't use feature groups. This is what I was really trying to uncover, whether the errors from
and
Again, in the case of |
So revisiting my comment from October 2, I think the right thing to do is
|
Getting very confused. I need to look at all the places where semantic connections are actually added to the end to end flow instance under construction. One such place is line 533. We aren't checking that the semantic connections actually connect. |
Fixed this by changing |
Okay, I was wrong, The error case can be triggered. This was uncovered by the unit tests for Issue #879. The case happens when the connections inside the component implementation "go around" the flow implementation. It becomes the opposite case of the error that is checked at the start of |
Summary
Flow path implementations can be between feature group features so as to be specify the exact route of the flow path. When the model is instantiated an end to end flow using such a flow path will follow that specific path only, and not all possible paths. This seems to be working fine. However, errors may be present on the instance model regarding the inability to connect the flow path with other incoming and outgoing connections because the flow path doesn't mention their start or end port, respectively.
Expected and Current Behavior
There should be no such such errors generated in this case because the point of specific flow path implementation is to indicate the exact path through the "feature group connection" that is of interest.
Steps to Reproduce
top.specific
e2e
top_specific_instance
These 2 errors are not appropriate in this case.
The text was updated successfully, but these errors were encountered: