Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AadlFileTypePropertyTester is very inefficient #2048

Closed
lwrage opened this issue Nov 7, 2019 · 0 comments · Fixed by #2096
Closed

AadlFileTypePropertyTester is very inefficient #2048

lwrage opened this issue Nov 7, 2019 · 0 comments · Fixed by #2096
Assignees
Milestone

Comments

@lwrage
Copy link
Contributor

lwrage commented Nov 7, 2019

Summary

The property tester distinguishes AADL package from property sets by fully loading the resource.

Expected and Current Behavior

The property tester should do the minimum amount of work necessary, i.e., read the start of the file and check if the first word after whitespace and comments is package or property.

Currently it fully processes the AADL file (parsing, linking, validation), which leads to processing all referenced AADL files, too.

Environment

  • OSATE Version: 2.6.0
  • Operating System: all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants