FHA: IndexOutOfBoundsException if likelihood unspecified

[jjhugues]

The following example triggers an exception

package foo
public
	system bar
		annex emv2 {**
			use behavior ErrorLibrary::FailStop; -- definition of error modes
			
			properties
				EMV2::severity => 1 applies to Failstop;
					--		EMV2::likelihood => C applies to Failstop;
				EMV2::hazards => ([crossreference => "";
						failure => "failure";
						phases => ("phases");
						description => "descr.";
						comment => "comment";
					]) applies to Failstop;
		**};
	end bar;

	system implementation bar.i
	end bar.i;
end foo;

java.lang.IndexOutOfBoundsException: Index: 0
at java.util.Collections$EmptyList.get(Collections.java:4454)
at org.osate.aadl2.errormodel.analysis.fha.FHAReport.reportHazardProperty(FHAReport.java:303)
at org.osate.aadl2.errormodel.analysis.fha.FHAReport.processHazards(FHAReport.java:138)
at org.osate.aadl2.errormodel.analysis.fha.FHAReport.doFHAReport(FHAReport.java:98)
at org.osate.aadl2.errormodel.analysis.handlers.FHAHandler.doAaxlAction(FHAHandler.java:70)
at org.osate.ui.handlers.AbstractAaxlHandler.processAaxlAction(AbstractAaxlHandler.java:482)
at org.osate.ui.handlers.AbstractAaxlHandler.actionBody(AbstractAaxlHandler.java:191)
at org.osate.ui.handlers.AaxlReadOnlyHandlerAsJob$ActionAsJob.runInWorkspace(AaxlReadOnlyHandlerAsJob.java:124)
at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:42)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

[jjhugues]

Trivial copy/paste error, patch is

index 534eecad2..d10fab341 100644
--- a/emv2/org.osate.aadl2.errormodel.analysis/src/org/osate/aadl2/errormodel/analysis/fha/FHAReport.java
+++ b/emv2/org.osate.aadl2.errormodel.analysis/src/org/osate/aadl2/errormodel/analysis/fha/FHAReport.java
@@ -301,7 +300,7 @@ public final class FHAReport {
} else {
// did not have a type set. Let's use fmr (state of type set as failure mode.
EMV2PropertyAssociation Sev = SevList.isEmpty() ? null : SevList.get(0);

•                                           EMV2PropertyAssociation Like = SevList.isEmpty() ? null : LikeList.get(0);
  

•                                           EMV2PropertyAssociation Like = LikeList.isEmpty() ? null : LikeList.get(0);