Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing validation for reference value with array indicies #2159

Closed
joeseibel opened this issue Jan 10, 2020 · 0 comments · Fixed by #2273
Closed

Missing validation for reference value with array indicies #2159

joeseibel opened this issue Jan 10, 2020 · 0 comments · Fixed by #2273

Comments

@joeseibel
Copy link
Contributor

joeseibel commented Jan 10, 2020

There are two validations that should be added when a reference value contains arrays in the path. Consider the following model:

package pkg1
public
  with ps1;

  system s1
    features
      f1: feature[];
      f2: feature[10];
    properties
      ps1::def1 => reference (f1[3]);
      ps1::def2 => reference (f2[4 .. 5]);
  end s1;
end pkg1;

There should be an error for def1 because the value contains an index, but f1 doesn't have a size. Additionally, there should be a warning for def2 stating that array ranges will not be properly instantiated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants