Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSATE allows aadl2 file extension for AADL files #2197

Closed
Etienne13 opened this issue Feb 11, 2020 · 6 comments · Fixed by #2227
Closed

OSATE allows aadl2 file extension for AADL files #2197

Etienne13 opened this issue Feb 11, 2020 · 6 comments · Fixed by #2227

Comments

@Etienne13
Copy link
Contributor

@Etienne13 Etienne13 commented Feb 11, 2020

Note: this issue is actually difficult to reproduce on other examples than the one referenced bellow. I tried to reproduce it on simpler examples but I did not manage to.

Summary

I use the example here during one of my courses. I ask students to complete the process implementation named control_application.impl. They have to add thread subcomponents, and connect them.

Steps to Reproduce

  1. Download the archive referenced above. Extract the content of the archive and import the project in it (File --> Import --> Existing project into workspace...)
  2. Create the Structure diagram for the process implementation control_application.impl in software.aadl
  3. From the textual editor, add a new thread in control_application.impl, say obst_detection2: thread obstacle_detection;

open the diagram of control_application.impl, obst_detection2 does not appear. Open the "Configure diagram" menu, obst_detection2 does not appear. Restart osate, and open the "Configure diagram" menu --> obst_detection2 does appear now.

Environment

  • OSATE Version: 2.7.0 but first noticed the issue in 2.5.3
  • Operating System: Linux Ubuntu and Debian
@lwrage
Copy link
Contributor

@lwrage lwrage commented Feb 11, 2020

New components are no longer automatically added to an existing diagram because it can destroy the layout if it was done manually, so that is not a bug. However, the new thread should show up in the "Configure Diagram" dialog and the outline view.

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Feb 11, 2020

@lwrage @Etienne13
The root cause of this is that the graphical editor only monitors changes to files with the ".aadl" extension. The files in the project have a ".aadl2" extension. From looking at other parts of the OSATE code it appears that support for the "aadl2" extension is mixed. It's easy enough to fix it on the graphical editor side but there are other features in OSATE that assume an "aadl" extension.

@Etienne13
Copy link
Contributor Author

@Etienne13 Etienne13 commented Feb 12, 2020

I tested with the aadl extension for my files and it works fine indeed. This also explains why I was not able to reproduce the issue after creating new aadl packages. Thanks for the information.

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Feb 12, 2020

@Etienne13 @lwrage since the text editor supports the aadl2 extension, I'm marking this as a GE bug to be fixed on the next release. However, I believe there are likely cases in other parts of OSATE which do not handle the "aadl2" extension.

@lwrage
Copy link
Contributor

@lwrage lwrage commented Feb 12, 2020

That aadl2 file extension is a leftover from the early days of our AADL2 implementation. It's probably better if we remove it.

@philip-alldredge
Copy link
Collaborator

@philip-alldredge philip-alldredge commented Feb 12, 2020

That works for me. If that's the path forward, then we should remove the GE tag. The graphical editor's behavior is a side effect of the partial support in core.

@lwrage lwrage added core and removed ge labels Feb 13, 2020
@lwrage lwrage changed the title In graphical editor, synchronization with the textual editor fails in one of my projects OSATE allows aadl2 file extension for AADL files Feb 13, 2020
@lwrage lwrage removed this from Increment 2 - 2020-05-29 in Graphical Editor Enhancements Feb 13, 2020
@lwrage lwrage assigned lwrage and unassigned philip-alldredge Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants