Behavior Annex: Null pointer exception when calling getContainingFeature() on an instance of StructUnionElement

[dblouin]

Summary

We use the EFM Compare framework to compare two AADL models having BA annex clauses. A null pointer exception occurs when comparing the models as shown in the trace below:

java.lang.NullPointerException
at org.eclipse.emf.ecore.impl.BasicEObjectImpl.eContainingFeature(BasicEObjectImpl.java:908)
at org.eclipse.emf.compare.match.eobject.EUriFragmentFunction.apply(EUriFragmentFunction.java:49)
at org.eclipse.emf.compare.match.eobject.EUriFragmentFunction.apply(EUriFragmentFunction.java:1)
at org.eclipse.emf.compare.match.eobject.URIDistance.retrieveFragment(URIDistance.java:187)
at org.eclipse.emf.compare.match.eobject.EditionDistance$1$1.matchingURIs(EditionDistance.java:143)
at org.eclipse.emf.compare.utils.EqualityHelper.matchingEObjects(EqualityHelper.java:251)
at org.eclipse.emf.compare.utils.EqualityHelper.matchingValues(EqualityHelper.java:170)
at
...

This occurs when calling eContainningFeature() on an instance of the StructUnionElement class of the BA metamodel.

The problem is due to the instance being added to the StructUnionElementHolder parent using the eBasicSetContainer() method passing the AadlBaPackage.STRUCT_UNION_ELEMENT_HOLDER as containing feature ID (see AadlBaTypeChecker class line 1357).

This is wrong since the passed ID is the ID of the StructUnionElementHolder class in the Ecore meta-model. As a matter of fact, there is a problem in the BA metamodel since there is no feature in the StructUnionElementHolder class to contain the StructUnionElement. The "element" reference of the StructUnionElementHolder class cannot be used for that since it is not containement.

I suggest adding an explicit reference in the StructUnionElementHolder class to contain StructUnionElement elements and modify the AadlBaTypeChecker class to use the proper reference constant.

Environment

• OSATE Version: 2.6.0
• Operating System: