Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming property set drops property set prefix from references to constants #2223

Closed
lwrage opened this issue Mar 4, 2020 · 1 comment · Fixed by #2225
Closed

Renaming property set drops property set prefix from references to constants #2223

lwrage opened this issue Mar 4, 2020 · 1 comment · Fixed by #2225

Comments

@lwrage
Copy link
Contributor

lwrage commented Mar 4, 2020

Summary

When renaming a property set with rename refactoring property constants that are defined and used in this property set lose their property set name prefix.

Steps to Reproduce

  1. Paste the model below in the AADL text editor
  2. Place the cursor on the property set name and hit Alt+Shift+R
  3. Change the property set name to PS1
  4. References to constant C1 are now C1 instead of PS1::C1
property set PS is
	C1: constant aadlinteger => 0;
	-- errors in the following 2 lines 
	C2: constant aadlinteger => PS::C1;
	P1: aadlinteger => PS::C1 applies to (all);
end PS;

Environment

  • OSATE Version: 2.7.0
  • Operating System: Linux
@lwrage
Copy link
Contributor Author

lwrage commented Mar 4, 2020

Content assist also inserts constant without property set name prefix, so it's a scoping bug.

@lwrage lwrage added this to the 2.7.1 milestone Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant