Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiation results dialog is annoying when instantiation is successful #2274

Closed
AaronGreenhouse opened this issue Apr 6, 2020 · 5 comments · Fixed by #2280
Closed

Instantiation results dialog is annoying when instantiation is successful #2274

AaronGreenhouse opened this issue Apr 6, 2020 · 5 comments · Fixed by #2280
Assignees
Milestone

Comments

@AaronGreenhouse
Copy link
Contributor

The instantiation results dialog always shows after completion, but it's annoying to make it go away each time.

There should be a workspace preference to only show it when there are unsuccessful instantiations.

@AaronGreenhouse
Copy link
Contributor Author

Added preference to there "OSATE > Instantiation" workspace preferences.

This is used by the instantiation and reinstantiation handlers to avoid showing the results dialog when all the jobs are successful.

@AaronGreenhouse
Copy link
Contributor Author

I added constants to OsateCorePlugin. From a versioning point of view, this is a big mistake. I have to move them somewhere else.

@AaronGreenhouse
Copy link
Contributor Author

I added constants to OsateCorePlugin. From a versioning point of view, this is a big mistake.

I changed the constants to be package visible instead of public. I had to add a few more public methods, but this only caused a minor version number change, which seems to have been less disruptive to the overall versioning.

@AaronGreenhouse
Copy link
Contributor Author

Changed the FlowLatencyDialog and the InstantiationResultsDialog to confirm the change to hide the dialog in the future.

@AaronGreenhouse
Copy link
Contributor Author

Updating the help text (Issue #2294)

Also want to add the context help for the dialogs and preference pane. (See branch of 1560 for how to do this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants