Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem serialization of event data PortSpecification instances #2300

Closed
philip-alldredge opened this issue Apr 28, 2020 · 3 comments · Fixed by #2303
Closed

Problem serialization of event data PortSpecification instances #2300

philip-alldredge opened this issue Apr 28, 2020 · 3 comments · Fixed by #2303
Assignees
Milestone

Comments

@philip-alldredge
Copy link
Collaborator

philip-alldredge commented Apr 28, 2020

While adding prototype support to the graphical editor, I've come across a serialization issue.

Steps to Reproduce

  1. Programatically create a FeaturePrototypeBinding and a PortSpecification with and event data category.
  2. Serialize back to AADL.
  3. The keyword used for event data is incorrect. eventData is serialized instead of event data.
package prototype_test
public
	with interfaces;
	with Base_Types;

	system subsystem
		prototypes
			iface_pt: feature group;
	end subsystem;

	system test_system
	end test_system;

	system implementation test_system.impl
		subcomponents
			ss: system subsystem (iface_pt => feature group interfaces::subsystem_interface (
					message_cpt => data Base_Types::String, event_fpt => out eventData port Base_Types::Integer));
	end test_system.impl;
end prototype_test;
@philip-alldredge
Copy link
Collaborator Author

philip-alldredge commented Apr 29, 2020

@lwrage this is blocking the current Graphical Editor prototype work(#2277) but I'm not knowledgeable enough in this area to suggest a fix. It appears to be caused by the xtext grammar or formatter. PortSpecification is the only part of the grammar to reference PortCategory. The prototype support branch is complete enough to easily test out fixes to this issue.

@lwrage lwrage self-assigned this Apr 29, 2020
@lwrage
Copy link
Contributor

lwrage commented Apr 29, 2020

@philip-alldredge Could you check if the change on branch 2300_serialize_event_data fixes the issue?

@philip-alldredge
Copy link
Collaborator Author

philip-alldredge commented Apr 29, 2020

@lwrage yes, the change in that branch fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants