Assurance View does not correctly render subclaims

[dvanbrug]

Summary

When creating a Verification Plan with nested subclaims, the “Assurance View” does not correctly render the Evidence or Description fields for the subclaims. All of the subclaims inherit the parent’s name / description instead of their own.

Expected and Current Behavior

Define a reqspec top level claim C1 and two nested claims C2 and C3 in the following structure:

• C1 – Claim 1

  • C2 – Claim 2

  • C3 – Claim 3

I would expect the “Assurance View” to display the Assurance Plan in a similar structure. Instead, it outputs the following:

• C1 – Claim 1

  • C1 – Claim 1

  • C1 – Claim 1

Steps to Reproduce

1.) Start with the following Alisa example: SimpleControlSystem (https://github.com/osate/alisa-examples/blob/master/SimpleControlSystem)

• An example of nested subclaims can be seen in the SimpleControlSystem/dualscsvplan.verify file:
  https://github.com/osate/alisa-examples/blob/master/SimpleControlSystem/SimpleControlSystem/alisa/dualscsvplan.verify

2.) However, this verification plan is not used in an Assurance Case. If we modify the SCSCase (SCSVerification.alisa) by adding the following assurance plan entry, we can cause these to be evaluated.


assurance plan DualSCSPlan for SimpleControlSystem::SCSDualPower.impl [
		assure DualSCSvplan
	]

3.) Add implementation to SimpleControlSystem.aadl


system implementation SCSDualPower.impl
end SCSDualPower.impl;


4.) Open the "Assurance View" and select the SCSCase Assurance Case. You should see something similar to the following image:

However, instead it should look the the next message:

Environment

• OSATE Version: 2.7.1
• Operating System: All

Proposed Fix

The following method constructClaimReferencePath is responsible for building the NestedClaimReference object that is used by the Assurance View. It appears that the method never adds the subclaim object.

Lines 490-498 in AssureConstructor.xtend

osate2/alisa/org.osate.assure/src/org/osate/assure/generator/AssureConstructor.xtend

Lines 490 to 498 in f3d0613

	def NestedClaimReference constructClaimReferencePath(Claim claim, NestedClaimReference ncr) {
	val parent = claim.eContainer
	if (parent instanceof Claim) {
	val NestedClaimReference parentNcr = factory.createNestedClaimReference
	parentNcr.requirement = parent.requirement
	return constructClaimReferencePath(parent, parentNcr)
	}
	return ncr
	}

If we add the following line after the creation of parentNcr (line 495), the subclaims are correctly added to the parent object.


parentNcr.sub = ncr


I will submit a pull request with this change as a possible fix.

[lwrage]

fixed