Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualified names removed from EMV2 type aliases #2398

Closed
philip-alldredge opened this issue Jul 27, 2020 · 1 comment · Fixed by #2471
Closed

Qualified names removed from EMV2 type aliases #2398

philip-alldredge opened this issue Jul 27, 2020 · 1 comment · Fixed by #2471
Assignees
Milestone

Comments

@philip-alldredge
Copy link
Collaborator

philip-alldredge commented Jul 27, 2020

Summary

When making a change to the error model library via the EMF model, the produced error annex library source may remove qualified names to point incorrect error types.

Expected and Current Behavior

When making a change to the error model, references should serialize to the correct qualified names.

Steps to Reproduce

  1. Create model with the following packages.
  2. Make a change to the typelib error model library.
  3. t1_alias no longer reference the correct t1.
package typelib
public
	annex EMV2 {**
		error types
			t1: type;
			t2: type;
			t1_alias renames type other_typelib::t1;
			t2_alias renames type t2;
			t3_alias renames type other_typelib::t3;
		end types;
	**};
end typelib; 
package other_typelib
public
		annex EMV2 {**
		error types
			t1 : type;
			t3 : type;
		end types;		
		**} ;
end other_typelib;

Example Resulting Model

package typelib
public
	annex EMV2 {**
		error types
			t1: type;
			t2: type;
			t1_alias renames type t1; -- THIS IS INCORRECT
			t2_alias renames type t2;
			t3_alias renames type other_typelib::t3;
			new_error_type: type;
		end types;
	**};
end typelib; 
@lwrage lwrage added this to the 2.9.0 milestone Aug 4, 2020
@lwrage lwrage assigned lwrage and unassigned joeseibel Oct 2, 2020
@lwrage
Copy link
Contributor

lwrage commented Oct 3, 2020

Bug in the emv2 cross-reference serializer. It always prefers local names if present even if the reference is to another package.

lwrage added a commit that referenced this issue Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants