You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Flow implementations name starting and/or ending feature. When renaming such a feature no renaming happens in flow implementations.
Expected and Current Behavior
Occurrences of features in flow implementations should be renamed during rename refactoring.
Note: Mark occurrence works for this case.
Steps to Reproduce
Select port p in S
Hit Alt+Shilt+R to start rename refactoring
No box appears around the reference to p in fsnk in S.i
Change the port name
Occurrence of p in fsnk is not renamed
package Issue2434
public
system S
features
p: in data port;
flows
fsnk: flow sink p;
end S;
system implementation S.i
subcomponents
sub: system subsystem;
connections
c1: port p -> sub.q;
flows
fsnk: flow sink p -> c1 -> sub;
end S.i;
system subsystem
features
q: in data port;
end subsystem;
end Issue2434;
Environment
OSATE Version: 2.8.0
Operating System: Ubuntu 20.04
The text was updated successfully, but these errors were encountered:
lwrage
changed the title
Rename reafctorng of part misses references in flow implementations
Rename refactoring of port misses references in flow implementations
Sep 14, 2020
This is a problem in Aadl2ScopeProvider.scope_FlowEnd_feature(FLowEnd...), where it is assumed the the flow end is contained in a FlowSpecification. In this case it is contained in a Flow_Implementation_. The ClassCastException is not propagated to the top level.
Also, scope_FlowEnd_feature(FlowEnd...) doesn't need to call the other scope_FlowEnd_feature method directly, this happens in the polymorphic dispatcher. The other method should just take a Flow parameter, which is a common superclass of FlowSpecification and FlowImplementation.
scope_FlowEnd_context(...) fails to handle flow implementations, too. Context parameter must have type ComponentClassifier.
Tests are in ConnectedElementsAndFlowEndsTest.xtend.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Flow implementations name starting and/or ending feature. When renaming such a feature no renaming happens in flow implementations.
Expected and Current Behavior
Occurrences of features in flow implementations should be renamed during rename refactoring.
Note: Mark occurrence works for this case.
Steps to Reproduce
p
inS
p
infsnk
inS.i
p
infsnk
is not renamedEnvironment
The text was updated successfully, but these errors were encountered: