Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classifier Info View should show the contents of the classifier selected in the hierarchy tree #2491

Closed
AaronGreenhouse opened this issue Oct 29, 2020 · 3 comments · Fixed by #2495
Assignees
Milestone

Comments

@AaronGreenhouse
Copy link
Contributor

Current the Classifier Information View has to panes:

  1. The left pane shows the classifier hierarchy tree; either the ancestors or the descendants of the selected classifier.
  2. the right pane shows all the members of the selected classifier.

The view should be more like the java type hiearchy view: When a classifier in the hierarchy pane is selected, the members pane should show the members of that classifier.

@AaronGreenhouse
Copy link
Contributor Author

AaronGreenhouse commented Oct 29, 2020

How the view should work:

  • Let H be the classifier used by the hierarchy pane

  • Let M be the classifier used by the member pane

  • When the view classifier is set/changed to C

    • H is set to C and the hierarchy pane in updated
    • M is set to C and the member pane is updated
  • When a refresh is required

    • If H no longer exists, then H and M are cleared and the panes are cleared.
    • if H exists then the hierarchy pane is updated
      • if M no longer exists then the member pane is cleared, otherwise it is updated
  • Clicking on a classifier C in the hierarchy pane

    • Sets M to C
    • Updates the member pane

@lwrage lwrage added this to the 2.9.1 milestone Oct 30, 2020
@AaronGreenhouse
Copy link
Contributor Author

AaronGreenhouse commented Nov 2, 2020

Above is too optimistic. Things are complicated by the fact that we don't really know what classes still exists after a refresh and that we don't explicitly show the name of the classifier whose members are being shown in the member pane.

What we have now is this:

  • Let H be the classifier used by the hierarchy pane

  • Let M be the classifier used by the member pane

  • When the view classifier is set/changed to C

    • H is set to C and the hierarchy pane in updated
    • M is set to C and the member pane is updated
  • When a refresh is required

    • If H no longer exists, then H and M are cleared and the panes are cleared.
    • if H exists then the hierarchy pane is updated, M is cleared, and the member pane is cleared.
  • When the hierarchy pane is changed from ancestor to descendants or vice versa

    • M is cleared and the the member pane is cleared. The other option here is to set the member pane to use the currently selected classifier in the hierarchy pane. This is trickier to do and potentially confusing. By clearing the members pane we force the user to explicitly select a classifier to view so they should be less confused.
  • Clicking on a classifier C in the hierarchy pane

    • Sets M to C
    • Updates the member pane

@AaronGreenhouse
Copy link
Contributor Author

Updated docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants