Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical editor uses inefficient property tester #2499

Closed
lwrage opened this issue Nov 4, 2020 · 1 comment · Fixed by #2504
Closed

Graphical editor uses inefficient property tester #2499

lwrage opened this issue Nov 4, 2020 · 1 comment · Fixed by #2504

Comments

@lwrage
Copy link
Contributor

lwrage commented Nov 4, 2020

Summary

Plugin org.osate.ge has a property tester (class org.osate.ge.internal.expressions.ResourcePropertyTester) to test if a file is an AADL package by loading the file into a resource set. This is horribly inefficient.

Expected and Current Behavior

The plugin should use org.osate.ui.handlers.AadlFileTypePropertyTester, instead. (We should put this one in a different package!)

Environment

  • OSATE Version: 2.9.0
  • Operating System: all
@philip-alldredge
Copy link
Collaborator

org.osate.ge.internal.expressions.ResourcePropertyTester also provides an additional name property that is no longer used. ResourcePropertyTester should be removed completely after switching to the property provided by aadlFileTypePropertyTester.

@lwrage lwrage added this to the 2.9.1 milestone Nov 5, 2020
@lwrage lwrage closed this as completed in 0285190 Nov 10, 2020
lwrage pushed a commit that referenced this issue Feb 16, 2022
Simplify enablement and visibility checks for open and create diagra
commmands. Closes #2499 and #2500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants