Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphical editor unnecessarily parses AADL file to enable handlers #2500

Closed
lwrage opened this issue Nov 4, 2020 · 0 comments · Fixed by #2504
Closed

Graphical editor unnecessarily parses AADL file to enable handlers #2500

lwrage opened this issue Nov 4, 2020 · 0 comments · Fixed by #2504
Assignees
@philip-alldredge
Labels
category:performance ge
Milestone
2.9.1

Comments

@lwrage
Copy link
Contributor

lwrage commented Nov 4, 2020

Summary

When right clicking on an AADL in the AADL navigator method setEnabled() of classes org.osate.ge.internal.ui.handlers.OpenDiagramHandler and ...CreateDiagramHandler is called. In both cases org.osate.ge.internal.ui.util.SelectionUtil.getDiagramContext(ISelection, IEditorPart) parses the AADL file. IIUC this is done to check if a package file is selected. This should be simplified to not parse the selected AADL file.

Similarly, right click on an aaxl2 file reads the instance file into memory. Maybe it is sufficient to just check the file extension.

Environment

  • OSATE Version: 2.9.0
  • Operating System: all
@philip-alldredge philip-alldredge mentioned this issue Nov 4, 2020
Closed
philip-alldredge added a commit that referenced this issue Nov 4, 2020
@philip-alldredge
Cleanup GE command enablement.
0285190 
Simplify enablement and visibility checks for open and create diagra
commmands. Closes #2499 and #2500
@philip-alldredge philip-alldredge mentioned this issue Nov 4, 2020
Merged
@lwrage lwrage added this to the 2.9.1 milestone Nov 5, 2020
lwrage pushed a commit that referenced this issue Feb 16, 2022
@philip-alldredge
Cleanup GE command enablement.
23f1c47 
Simplify enablement and visibility checks for open and create diagra
commmands. Closes #2499 and #2500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philip-alldredge philip-alldredge

Labels
category:performance ge
Projects
None yet
Milestone
2.9.1
Development

Successfully merging a pull request may close this issue.

Cleanup GE command enablement. osate/osate2
2 participants
@lwrage @philip-alldredge