Skip to content

Graphical editor unnecessarily parses AADL file to enable handlers #2500

Description

@lwrage

Summary

When right clicking on an AADL in the AADL navigator method setEnabled() of classes org.osate.ge.internal.ui.handlers.OpenDiagramHandler and ...CreateDiagramHandler is called. In both cases org.osate.ge.internal.ui.util.SelectionUtil.getDiagramContext(ISelection, IEditorPart) parses the AADL file. IIUC this is done to check if a package file is selected. This should be simplified to not parse the selected AADL file.

Similarly, right click on an aaxl2 file reads the instance file into memory. Maybe it is sufficient to just check the file extension.

Environment

  • OSATE Version: 2.9.0
  • Operating System: all

Metadata

Metadata

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions