Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate property set accessor code for org.osate.contribution.sei #2573

Closed
AaronGreenhouse opened this issue Feb 11, 2021 · 3 comments · Fixed by #2590
Closed

Generate property set accessor code for org.osate.contribution.sei #2573

AaronGreenhouse opened this issue Feb 11, 2021 · 3 comments · Fixed by #2590
Assignees
@AaronGreenhouse
Labels
category:enhancement core
Milestone
2.9.2

Comments

@AaronGreenhouse
Copy link
Contributor

Summary

The property set accessor code the property sets provided by org.osate.contribution.sei should be generated (using the tool in org.osate.propertiescodegen and put into this project.
@AaronGreenhouse AaronGreenhouse self-assigned this Feb 11, 2021
@AaronGreenhouse
Copy link
Contributor Author

See https://github.com/osate/osate2/wiki/Properties-Code-Generator

@AaronGreenhouse
Copy link
Contributor Author

  • Added generated code to org.osate.contribution.sei in a new src-gen directory.
  • Added @codegen-package tags to the property set definitions
  • Deprecated the classes in org.osate.contribution.sei.names
  • Deprecated the class GetProperties in project org.osate.xtext.aadl2.properties
  • Removed the the dependency on org.osate.contribution.sei from org.osate.xtext.aadl2.properties

@AaronGreenhouse AaronGreenhouse mentioned this issue Feb 23, 2021
Merged
@lwrage lwrage added this to the 2.9.2 milestone Mar 7, 2021
@lwrage
Copy link
Contributor

lwrage commented Mar 7, 2021

Please add "Will be removed in 2.10.0" to the @deprecated javadoc tag so people know what to expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AaronGreenhouse AaronGreenhouse

Labels
category:enhancement core
Projects
None yet
Milestone
2.9.2
Development

Successfully merging a pull request may close this issue.

Added generated property set code to org.osate.contribution.sei osate/osate2
2 participants
@lwrage @AaronGreenhouse