Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In BA plugin, fail to open provided examples #2583

Closed
Etienne13 opened this issue Feb 18, 2021 · 5 comments · Fixed by #2642
Closed

In BA plugin, fail to open provided examples #2583

Etienne13 opened this issue Feb 18, 2021 · 5 comments · Fixed by #2642
Assignees
Milestone

Comments

@Etienne13
Copy link
Contributor

Summary

Some of the Behavior Annex examples, provided with the plugin, cannot be open by the editor.

Expected behavior
Import, open and edit examples provided with the behavior annex plugin

Actual behavior
When opening some of these examples, inconsistent error messages appear (due to exceptions in the BA plugin) or the editor crashes.

Steps To Reproduce

  1. Go to 'File'
  2. Click on 'New --> Examples...'
  3. Import all the Behavior Annex examples
  4. See errors.

Desktop (please complete the following information):

  • OSATE Version: 9.2.1
  • Operating System: Linux

Additional context
Some of the errors are expected; but I don't think it is a good idea to provide erroneous examples (they are tests, not examples).
Some of the errors are bugs (regressions); either in the models (e.g. modes) or in the plugin (class cast exceptions).

A cleanup is necessary.

@jjhugues
Copy link
Contributor

In addition, OSATE now has a different wizard for examples with additional features like showing a README. You might consider migrating and use this one instead

@Etienne13 Etienne13 self-assigned this Feb 18, 2021
@Etienne13 Etienne13 added the ba label Feb 18, 2021
@Etienne13 Etienne13 added this to the 2.9.2 milestone Feb 18, 2021
@Etienne13
Copy link
Contributor Author

@jjhugues Can you point to an example so I can see how the new wizard works? Thanks!

@jjhugues
Copy link
Contributor

File -> New -> Example

The rest is basic Eclipse plugin machinery, see https://github.com/osate/osate2/tree/master/examples
the core is in this xml file that points to examples, README, etc: https://github.com/osate/osate2/blob/master/examples/org.osate.examples/plugin.xml

@lwrage
Copy link
Contributor

lwrage commented Apr 8, 2021

@Etienne13 Should this be moved to the next release (2.10.0)?

@Etienne13
Copy link
Contributor Author

@lwrage the initial issue is fixed in branch 2583; I could not work on the examples documentation as suggested by Jerôme. I think the release you are preparing should include the existing fix. I will prepare the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants