Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error/warning markers in AADL navigator view #2609

lwrage opened this issue Mar 5, 2021 · 2 comments · Fixed by #2614

Missing error/warning markers in AADL navigator view #2609

lwrage opened this issue Mar 5, 2021 · 2 comments · Fixed by #2614


Copy link

lwrage commented Mar 5, 2021

The AADL Navigator no longer shows error markers on elements in expanded AADL model files.

This used to work in previous versions.

Steps To Reproduce

  1. Paste model below into AADL editor and save it as P.aadl.
  2. Expand P.aadl file in AADL navigator
  3. The file contains error markers on flow implementations for fl
  4. No error markers on flows in the AADL navigator
package P

	thread T
			i: in data port;
			o: out data port;
			fl: flow path i -> o;
	end T;

	thread implementation T.i
			seq: {
				cl: subprogram SP;
			pc1: parameter i -> cl.pi;
			pc2: parameter cl.po -> o;
			-- cannot specify flow through called subprogram
			-- both of the following are not allowed
			fl: flow path i -> pc1 -> cl -> pc2 -> o;
			fl: flow path i -> pc1 -> cl.fp -> pc2 -> o;
	end T.i;

	subprogram SP
			pi: in parameter;
			po: out parameter;
			fp: flow path pi -> po;
	end SP;
end P;

OSATE 2.9.0:

OSATE 2.9.1:

Desktop (please complete the following information):

  • OSATE Version: 2.9.1
  • Operating System: Linux, Windows
@lwrage lwrage added this to the 2.9.2 milestone Mar 5, 2021
@lwrage lwrage assigned lwrage and unassigned lwrage Mar 5, 2021
Copy link
Contributor Author

lwrage commented Mar 5, 2021

This is caused by the fix to #2430.

Copy link

Problem wasn't the imaging caching. I thought maybe I wasn't including the decorations correctly, but I was. The problem was that the original EObject represented by the wrapper was coming from a different ResourceSetImpl than the was being used when looking at the markers of any children. That meant the EcoreUtil.isAncestor() predicate was always returning false. I changed the factory to be able to share the resource set used by the caller in AadlElementContentProvider.getChildren().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging a pull request may close this issue.

2 participants