Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error/warning markers on instance model elements #2612

Closed
lwrage opened this issue Mar 5, 2021 · 2 comments · Fixed by #2616
Closed

Missing error/warning markers on instance model elements #2612

lwrage opened this issue Mar 5, 2021 · 2 comments · Fixed by #2616
Assignees
Milestone

Comments

@lwrage
Copy link
Contributor

lwrage commented Mar 5, 2021

Summary
Instance editor and AADL navigator no longer show any error or warning markers on instance objects.

This used to work in OSATE 2.9.0.

Steps To Reproduce

  1. Add model below in an AADL project
  2. Instantiate S.i
  3. Open instance model in instance editor
  4. Expand instance model in navigator
package Issue2612
public
	
	system S
	end S;
	
	system implementation S.i
		subcomponents
			l: system L;
			m: system M.i;
			r: system R;
		connections
			lm: feature l.o -> m.i;
			mr: feature m.o -> r.i;
		flows
			ee: end to end flow l.src -> lm -> m.pth -> mr -> r.snk;
	end S.i;
	
	system L
		features
			o: out feature;
		flows
			src: flow source o;
	end L;
	
	system M
		features
			i: in feature;
			o: out feature;
		flows
			pth: flow path i -> o;
	end M;
	
	system implementation M.i
		subcomponents
			mm: system M;
		connections
			imm: feature i -> mm.i;
	end M.i;
	
	system R
		features
			i: in feature;
		flows
			snk: flow sink i;
	end R;
	
end Issue2612;

Screenshots
OSATE 2.9.1:
image

OSATE 2.9.0:
image

Desktop (please complete the following information):

  • OSATE Version: 2.9.1
  • Operating System: Linux, Windows

Additional context
Maybe caused by the fix to #2430.

@AaronGreenhouse
Copy link
Contributor

Same problem as Issue #2609. Fix for 2609 fixes this too.

@lwrage
Copy link
Contributor Author

lwrage commented Mar 8, 2021

Only navigator markers are #2609. Missing markers in the instance editor are the main issue. This is caused by switching back to the EMF generated model editor which doesn't have that functionality.

@lwrage lwrage reopened this Mar 8, 2021
@AaronGreenhouse AaronGreenhouse self-assigned this Mar 9, 2021
@lwrage lwrage assigned lwrage and unassigned AaronGreenhouse Mar 9, 2021
@lwrage lwrage linked a pull request Mar 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants