Missing validation for reserved thread ports

[lwrage]

Summary

Threads have a couple of reserved ports: The Complete out event port, Error out event data port, Abort out event port, and Stop out event port are reserved, i.e., they must be declared of the specified port type. OSATE should validate that these ports are declared correctly, but doesn't.

See 5.4 (L3) in the AADL 2.2 standard.

Expected behavior
A port named complete should be valid only as an out event port, etc.

Actual behavior
There is no validation, e.g. complete can be declared as an in data port without an error in the model.

Steps To Reproduce

1. Paste model below into the AADL text editor

package ReservedPorts
public

  thread Correct
    features
      complete: out event port;
      error: out event data port;
      abort: out event port;
      stop: out event port;
  end Correct;

  thread Invalid
    features
      -- there should be errors on each feature
      complete: in data port;
      error: in event port;
      abort: out event data port;
      stop: in event port;
  end Invalid;
  
end ReservedPorts;

Desktop (please complete the following information):

• OSATE Version: 2.9.2
• Operating System: Linux