Mode transition names are ignored during instantiation

[lwrage]

Summary

When instantiating a model with mode transitions, the names for the mode transition instances are not as expected.

Expected behavior

A named mode transition should retain that name if instantiated. The instance name for an unnamed mode transition can be generated.

Actual behavior

All mode transition names in the instance model are generated; names from the node transition declaration are ignored.

Steps To Reproduce

1. Instantiate S.i in the model below
2. Open the instance model
3. See that there is one mode transition named m1_p_m2

package Issue2933
public
  system S
    features
      p: in event port;
  end S;

  system implementation S.i
    modes
      m1: initial mode;
      m2: mode;
      mt1: m1 -[p]-> m2;
  end S.i;

end Issue2933;

Desktop (please complete the following information):

• OSATE Version: 2.16
• Operating System: all

[lwrage]

Note that fixing this requires updates to test in various plugins.