Missing consistency checks for connection instances

[lwrage]

For AADLv1 there was a consistency check for semantic connections during instantiation. These checks need to be updated for AADLv2.

[lwrage]

Check would detect that connection ends are refined in a way that makes the connection instance invalid.

[AaronGreenhouse]

• Check what's in CheckInstanceSemanticsSwitch
• Consider refinement of abstract features; Consider refinement of ports with classifiers
  • Refinement can make vague things that were legal into specific things that are not legal

Put new checks in ValidateConnectionsSwitch

(I looked through the history of InstantiateModel, but I didn't see any big blocks of commented out code.

[AaronGreenhouse]

Not sure that any of the checks in CheckInstanceSemanticsSwitch make sense to bring back. They are from my very strict interpretation of the "complete system" rules from way back when.