Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: support for repo package sets #82

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

gicmo
Copy link
Contributor

@gicmo gicmo commented Feb 14, 2022

This adds support for specifing the package sets for repositories; on the command line this can be done via --repo-package-set with and argument of ; separated package set names. This will result in repo information being transported via dict instead of plain strings. Thus the hub plugin's schema was modified accordingly. Last but not least, the builder plugin now can decode these dicts and setup the repos accordingly.
Test were added for plugins as well as the integration test changed to use this new feature.
The first upstream commit that supports this feature is pinned.

achilleas-k
achilleas-k previously approved these changes Feb 14, 2022
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That dual arg parsing combo is pretty cool!

plugins/builder/osbuild.py Outdated Show resolved Hide resolved
When we are on an RHEL 8.x host we need to supply `rhel-8x` as
target distro. The previous code just used the major version so
we always built `rhel-8`, i.e. RHEL 8.3.
This adds support for specifing the package sets for repositories;
on the command line this can be done via `--repo-package-set` with
and argument of `;` separated package set names. This will result
in repo information being transported via dict instead of plain
strings. Thus the hub plugin's schema was modified accordingly.
Last but not least, the builder plugin now can decode these dicts
and setup the repos accordingly.
Test were added for plugins as well as the integration test changed
to use this new feature.
The first upstream commit that supports this feature is pinned.
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achilleas-k achilleas-k enabled auto-merge (rebase) February 15, 2022 14:41
@achilleas-k achilleas-k merged commit f559c18 into osbuild:main Feb 15, 2022
@gicmo gicmo deleted the package_sets branch February 15, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants