Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHEL 9.0: use C.UTF-8 for images that only have glibc-minimal-langpack #2206

Closed
gicmo opened this issue Jan 20, 2022 · 6 comments · Fixed by #2351
Closed

RHEL 9.0: use C.UTF-8 for images that only have glibc-minimal-langpack #2206

gicmo opened this issue Jan 20, 2022 · 6 comments · Fixed by #2351
Assignees
@thozza
Labels
bug Something isn't working

Comments

@gicmo
Copy link
Contributor

gicmo commented Jan 20, 2022

We currently set en_US.UTF-8 for all images:

osbuild-composer/internal/distro/rhel90/distro.go

Line 60 in 1c2c97c

Locale: "en_US.UTF-8",

According to the glib team, if glibc-minimal-langpack is installed, only C.UTF-8 is available.

The following images should be affected:

Images that install langpacks-en:

I took this info from the package sets. Maybe need to verify it by looking at the fully dep-solved package list.

Downstream bug: rhbz#2000878
@gicmo gicmo added bug Something isn't working rhel9 labels Jan 20, 2022
@teg
Copy link
Member

teg commented Feb 22, 2022

Should we not aim for uniformity and just go C.UTF-8 everywhere?

@gicmo
Copy link
Contributor Author

gicmo commented Feb 22, 2022

Should we not aim for uniformity and just go C.UTF-8 everywhere?

That was my first intuition as well, but it is quite late to change the default. But I am torn.

@gicmo
Copy link
Contributor Author

gicmo commented Feb 22, 2022

If we do set C.UTF-8 everywhere we should probably also remove langpacks-en from the images.

@gicmo
Copy link
Contributor Author

gicmo commented Feb 22, 2022

One other note: if a users sets a locale in the customisation, do we install the corresponding langpack? Or is that up to the user?

@teg
Copy link
Member

teg commented Feb 22, 2022

We should. But I don't recall if that's still a TODO.

@thozza thozza self-assigned this Feb 23, 2022
@thozza
Copy link
Member

thozza commented Feb 23, 2022

Affected image types:

$ grep  -L "langpack-en" test/data/manifests/rhel_90-x86_64*
test/data/manifests/rhel_90-x86_64-edge_commit-boot.json
test/data/manifests/rhel_90-x86_64-edge_commit_rt-boot.json
test/data/manifests/rhel_90-x86_64-edge_container-boot.json
test/data/manifests/rhel_90-x86_64-image_installer-boot.json
test/data/manifests/rhel_90-x86_64-qcow2-boot.json
test/data/manifests/rhel_90-x86_64-qcow2_customize-boot.json
test/data/manifests/rhel_90-x86_64-tar-boot.json

thozza added a commit to thozza/osbuild-composer that referenced this issue Feb 23, 2022
@thozza
RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack
dd49759 
Change the default locale to `C.UTF-8` for the following images, which
do not contain `glibc-minimal-langpack` in their default package set:
 - edge-commit
 - edge-container
 - image-installer
 - qcow2
 - tar

Also change the default locale for the edge-simplified-installer
installer-tree pipeline, since its package set contains only
`glibc-minimal-langpack`.

Regenerate RHEL-90 and c9s image tests.

Fix osbuild#2206

Signed-off-by: Tomas Hozza <thozza@redhat.com>
@thozza thozza mentioned this issue Feb 23, 2022
Merged
4 tasks
thozza added a commit to thozza/osbuild-composer that referenced this issue Feb 23, 2022
@thozza
RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack
d5987c7 
Change the default locale to `C.UTF-8` for the following images, which
do not contain `glibc-minimal-langpack` in their default package set:
 - edge-commit
 - edge-container
 - image-installer
 - qcow2
 - tar

Also change the default locale for the edge-simplified-installer
installer-tree pipeline, since its package set contains only
`glibc-minimal-langpack`.

Regenerate RHEL-90 and c9s image tests.

Fix osbuild#2206

Signed-off-by: Tomas Hozza <thozza@redhat.com>
thozza added a commit to thozza/osbuild-composer that referenced this issue Feb 24, 2022
@thozza
RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack
87dfcdd 
Change the default locale to `C.UTF-8` for RHEL-9.0.
For all the images which install `langpack-en`, keep using the
`en_US.UTF-8` locale. `C.UTF-8` is used as the default for:
 - edge-commit
 - edge-container
 - image-installer
 - qcow2
 - tar

Also change the default locale for the edge-simplified-installer
installer-tree pipeline, since its package set contains only
`glibc-minimal-langpack`.

Regenerate RHEL-90 and c9s image tests.

Fix osbuild#2206

Signed-off-by: Tomas Hozza <thozza@redhat.com>
thozza added a commit to thozza/osbuild-composer that referenced this issue Feb 24, 2022
@thozza
RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack
9a23857 
Change the default locale to `C.UTF-8` for RHEL-9.0.
For all the images which install `langpack-en`, keep using the
`en_US.UTF-8` locale. `C.UTF-8` is used as the default for:
 - edge-commit
 - edge-container
 - image-installer
 - qcow2
 - tar

Also change the default locale for the edge-simplified-installer
installer-tree pipeline, since its package set contains only
`glibc-minimal-langpack`.

Regenerate RHEL-90 and c9s image tests.

Fix osbuild#2206

Signed-off-by: Tomas Hozza <thozza@redhat.com>
thozza added a commit to thozza/osbuild-composer that referenced this issue Feb 24, 2022
@thozza
RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack
b063b37 
Change the default locale to `C.UTF-8` for RHEL-9.0.
For all the images which install `langpack-en`, keep using the
`en_US.UTF-8` locale. `C.UTF-8` is used as the default for:
 - edge-commit
 - edge-container
 - image-installer
 - qcow2
 - tar

Also change the default locale for the edge-simplified-installer
installer-tree pipeline, since its package set contains only
`glibc-minimal-langpack`.

Regenerate RHEL-90 and c9s image tests.

Fix osbuild#2206

Signed-off-by: Tomas Hozza <thozza@redhat.com>
thozza added a commit to thozza/osbuild-composer that referenced this issue Feb 25, 2022
@thozza
RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack
e8256f5 
Change the default locale to `C.UTF-8` for RHEL-9.0.
For all the images which install `langpack-en`, keep using the
`en_US.UTF-8` locale. `C.UTF-8` is used as the default for:
 - edge-commit
 - edge-container
 - image-installer
 - qcow2
 - tar

Also change the default locale for the edge-simplified-installer
installer-tree pipeline, since its package set contains only
`glibc-minimal-langpack`.

Regenerate RHEL-90 and c9s image tests.

Fix osbuild#2206

Signed-off-by: Tomas Hozza <thozza@redhat.com>
thozza added a commit to thozza/osbuild-composer that referenced this issue Feb 25, 2022
@thozza
RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack
035a864 
Change the default locale to `C.UTF-8` for RHEL-9.0.
For all the images which install `langpack-en`, keep using the
`en_US.UTF-8` locale. `C.UTF-8` is used as the default for:
 - edge-commit
 - edge-container
 - image-installer
 - qcow2
 - tar

Also change the default locale for the edge-simplified-installer
installer-tree pipeline, since its package set contains only
`glibc-minimal-langpack`.

Regenerate RHEL-90 and c9s image tests.

Fix osbuild#2206

Signed-off-by: Tomas Hozza <thozza@redhat.com>
gicmo pushed a commit to thozza/osbuild-composer that referenced this issue Feb 26, 2022
@thozza @gicmo
RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack
eae51df 
Change the default locale to `C.UTF-8` for RHEL-9.0.
For all the images which install `langpack-en`, keep using the
`en_US.UTF-8` locale. `C.UTF-8` is used as the default for:
 - edge-commit
 - edge-container
 - image-installer
 - qcow2
 - tar

Also change the default locale for the edge-simplified-installer
installer-tree pipeline, since its package set contains only
`glibc-minimal-langpack`.

Regenerate RHEL-90 and c9s image tests.

Fix osbuild#2206

Signed-off-by: Tomas Hozza <thozza@redhat.com>
gicmo pushed a commit that referenced this issue Feb 26, 2022
@thozza @gicmo
RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack
ccd0be8 
Change the default locale to `C.UTF-8` for RHEL-9.0.
For all the images which install `langpack-en`, keep using the
`en_US.UTF-8` locale. `C.UTF-8` is used as the default for:
 - edge-commit
 - edge-container
 - image-installer
 - qcow2
 - tar

Also change the default locale for the edge-simplified-installer
installer-tree pipeline, since its package set contains only
`glibc-minimal-langpack`.

Regenerate RHEL-90 and c9s image tests.

Fix #2206

Signed-off-by: Tomas Hozza <thozza@redhat.com>
@spuliaiev-sfdc spuliaiev-sfdc mentioned this issue Aug 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thozza thozza

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RHEL-90: use C.UTF-8 for images that only have glibc-minimal-langpack thozza/osbuild-composer
3 participants
@gicmo @teg @thozza