distro/rhel90: enable edge-simplified-installer image type #2015

achilleas-k · 2021-11-15T14:49:41Z

This reverts commit 226ada6.

This PR replaces #2010 and (I think) #1744.

achilleas-k · 2021-11-15T23:48:28Z

Changed RHEL 9.0 edge-simplified-installer to use coreos-installer-dracut, based on RHEL 8.6 changes by @runcom in PR #1752.

henrywang · 2021-11-16T03:30:50Z

@achilleas-k I found the error DNF error occured: MarkingErrors: Error occurred when marking packages for installation: Problems in request:\nmissing packages: coreos-installer, coreos-installer-dracut. Looks the cdn repo does not have coreos-installer included, but nightly has.

runcom · 2021-11-16T08:08:54Z

Shouldn’t we just update the osbuild mirror? Or use nightly (to also unblock my other PRs for 8.6

jrusz · 2021-11-16T09:09:20Z

It's actually using rpmrepo snapshot for the repositories and I guess that doesn't have the package in it yet... You can see it if you look for composer-cli sources list in the log...

++ sudo composer-cli sources list
+ for SOURCE in $(sudo composer-cli sources list)
+ sudo composer-cli sources info appstream
check_gpg = false
check_ssl = true
id = "appstream"
name = "appstream"
rhsm = false
system = true
type = "yum-baseurl"
url = "https://rpmrepo.osbuild.org/v2/mirror/rhvpn/el9/el9-x86_64-appstream-n9.0-20211105/"
+ for SOURCE in $(sudo composer-cli sources list)
+ sudo composer-cli sources info baseos
check_gpg = false
check_ssl = true
id = "baseos"
name = "baseos"
rhsm = false
system = true
type = "yum-baseurl"
url = "https://rpmrepo.osbuild.org/v2/mirror/rhvpn/el9/el9-x86_64-baseos-n9.0-20211105/"
+ for SOURCE in $(sudo composer-cli sources list)
+ sudo composer-cli sources info rt
check_gpg = false
check_ssl = true
id = "rt"
name = "rt"
rhsm = false
system = true
type = "yum-baseurl"
url = "https://rpmrepo.osbuild.org/v2/mirror/rhvpn/el9/el9-x86_64-rt-n9.0-20211105/"

This happens during sourcing tools/provision.sh https://github.com/osbuild/osbuild-composer/blob/main/tools/provision.sh#L75

achilleas-k · 2021-11-16T12:30:19Z

I asked Tomas to create a new repo snapshot and I'll update the repo links once it's done.

internal/distro/rhel90/stage_options.go

internal/distro/rhel90/pipelines.go

runcom · 2021-11-16T13:25:13Z

I asked Tomas to create a new repo snapshot and I'll update the repo links once it's done.

~~we need a new snapshot for 8.6 as well for the 8.6 PR version of this too as that's failing too cause there's no coreos-installer-dracut in rpmrepo.osbuild #1752~~

This also needs rdma-core in the package set of the simplified installer

achilleas-k · 2021-11-16T13:44:37Z

Updated the test repositories and rebased on main.

@runcom the new repository snapshots include 8.6 as well.

runcom · 2021-11-17T13:13:00Z

internal/distro/rhel90/pipelines.go

 	p.AddStage(osbuild.NewLocaleStage(&osbuild.LocaleStageOptions{Language: "en_US.UTF-8"}))
-	p.AddStage(osbuild.NewSystemdStage(systemdStageOptions([]string{"coreos-installer"}, nil, nil, "")))
-	p.AddStage(osbuild.NewDracutStage(dracutStageOptions(kernelVer, arch, []string{"rdcore"})))
+	p.AddStage(osbuild.NewDracutStage(dracutStageOptions(kernelVer, arch, []string{"coreos-installer"})))


looks like the test in rhel9 can't find this module even if coreos-installer-dracut is installed?

nevermind, rebuilding the package cause of a bug in how it installs dracut modules on the system

we'd need a new rpmrepo snapshot too

runcom · 2021-11-19T15:48:02Z

I think we can also get #2045 before this so we don't introduce rdma-core - we don't need that in the simplified installer at all

achilleas-k · 2021-11-19T18:02:20Z

This requires coreos-installer-dracut version 0.10.1-4, which should appear in the nightly composes next week.

runcom · 2021-11-20T09:00:48Z

This requires coreos-installer-dracut version 0.10.1-4, which should appear in the nightly composes next week.

it's now in the nightly repos - we need another snapshot and we should be good to go 👍

internal/distro/rhel90/package_sets.go

runcom · 2021-11-23T09:11:24Z

@achilleas-k can we request/do another snapshot to make test pass here? last nightlies contain the package we need with the correct version

achilleas-k · 2021-11-23T15:19:48Z

Pointed test repos to today's snapshot

runcom · 2021-11-23T18:06:10Z

Looks like some resource constraints in CI

runcom · 2021-11-24T09:14:54Z

Google api error 😅

This reverts commit 226ada6.

Signed-off-by: Achilleas Koutsou <achilleas@koutsou.net>

No longer necessary. See fed8edc

achilleas-k · 2021-11-24T15:31:49Z

Also needed a rebase on main

runcom · 2021-11-24T18:31:13Z

looks like mkfs.fat in osbuild has some issues https://gitlab.com/osbuild/ci/osbuild-composer/-/jobs/1816235011#L3130
apart from that, I think coreos-installer-dracut is now properly working in RHEL9 :)

achilleas-k · 2021-11-25T10:28:33Z

looks like mkfs.fat in osbuild has some issues https://gitlab.com/osbuild/ci/osbuild-composer/-/jobs/1816235011#L3130 apart from that, I think coreos-installer-dracut is now properly working in RHEL9 :)

Posted in chat but should've commented here:
Empty volid is invalid in mkfs.fat (I guess it was always invalid, but they fixed the validation in the latest release):
dosfstools/dosfstools@07e63ac

You can omit the flag entirely in the command, but in osbuild it's required in the stage options:
https://github.com/osbuild/osbuild/blob/2e9ffaf517e1d717be2f588baea98794b0f21ae3/stages/org.osbuild.mkfs.fat#L32

so not specifying it means it gets passed as empty string, which breaks now.

achilleas-k · 2021-11-26T14:35:06Z

coreos-installer needs an another update/fix for this. It removes the initrd-release file in the initramfs, which seems to upset systemd now.

Generate a random 32-bit hex string

runcom · 2021-11-30T08:41:23Z

coreos-installer needs an another update/fix for this. It removes the initrd-release file in the initramfs, which seems to upset systemd now.

the fix landed in nightlies, we can snapshot that, update the manifests and retest tests here

henrywang · 2021-12-01T15:29:41Z

@achilleas-k Tests on RHEL 9.0 failed at DNF error occured: RepoError: Error occurred when setting up repo: Failed to download metadata for repo '0': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
I think the nightly compose repo URL should be http://download.devel.redhat.com/rhel-9/nightly/RHEL-9/latest-RHEL-9.0/compose/BaseOS/x86_64/os. The repo URL needs /os.

achilleas-k · 2021-12-01T16:16:40Z

Thanks @henrywang. I neglected this PR again. Changing now.

Temporarily switch to the nightly devel composes for RHEL 9.0. We're testing new packages and changes right now (like coreos-installer) and it takes time to make new snapshots every time. Signed-off-by: Achilleas Koutsou <achilleas@koutsou.net>

runcom · 2021-12-02T10:35:31Z

LGTM :)

achilleas-k requested review from diaasami and henrywang November 15, 2021 14:51

henrywang mentioned this pull request Nov 16, 2021

test: Enable OSTree simplified installer test on RHEL 9 #2010

Closed

diaasami previously approved these changes Nov 16, 2021

View reviewed changes

runcom reviewed Nov 16, 2021

View reviewed changes

internal/distro/rhel90/stage_options.go Outdated Show resolved Hide resolved

runcom reviewed Nov 16, 2021

View reviewed changes

internal/distro/rhel90/pipelines.go Outdated Show resolved Hide resolved

achilleas-k dismissed diaasami’s stale review via 43aecdb November 16, 2021 13:41

achilleas-k force-pushed the distro/rhel9/edge-simplified-installer branch from 43aecdb to 0b42eb0 Compare November 16, 2021 13:42

achilleas-k force-pushed the distro/rhel9/edge-simplified-installer branch 2 times, most recently from 5a8f682 to e7ecd59 Compare November 16, 2021 13:54

runcom reviewed Nov 17, 2021

View reviewed changes

runcom reviewed Nov 20, 2021

View reviewed changes

internal/distro/rhel90/package_sets.go Outdated Show resolved Hide resolved

runcom mentioned this pull request Nov 20, 2021

simplified installer (8/9): support FDO #1884

Merged

4 tasks

achilleas-k force-pushed the distro/rhel9/edge-simplified-installer branch from e7ecd59 to c1ca4fd Compare November 22, 2021 13:09

achilleas-k force-pushed the distro/rhel9/edge-simplified-installer branch from c1ca4fd to 18b092e Compare November 23, 2021 15:14

distro/rhel90: enable edge-simplified-installer image type

e751487

This reverts commit 226ada6.

achilleas-k added 3 commits November 24, 2021 16:31

distro/rhel90: use coreos-installer-dracut

2aa6cfe

Signed-off-by: Achilleas Koutsou <achilleas@koutsou.net>

test/data: update RHEL 9.0 test repositories

c75f2b8

distro/rhel90: remove rdma-core for simplified-installer

36d7235

No longer necessary. See fed8edc

achilleas-k force-pushed the distro/rhel9/edge-simplified-installer branch from 18b092e to 36d7235 Compare November 24, 2021 15:31

achilleas-k added 2 commits November 26, 2021 16:37

disk: random volume ID generator for FAT

33c7e4d

Generate a random 32-bit hex string

distro/rhel90: assign random volid for efiboot.img

bd942d4

achilleas-k force-pushed the distro/rhel9/edge-simplified-installer branch from 238c104 to bd942d4 Compare November 26, 2021 15:46

runcom mentioned this pull request Nov 30, 2021

simplified-installer: add clevis dracut and needed kargs for COI #2077

Closed

3 tasks

achilleas-k force-pushed the distro/rhel9/edge-simplified-installer branch from 30f7c3e to 2535386 Compare December 1, 2021 16:18

lavocatt approved these changes Dec 2, 2021

View reviewed changes

achilleas-k merged commit 24b8373 into osbuild:main Dec 2, 2021

achilleas-k deleted the distro/rhel9/edge-simplified-installer branch December 2, 2021 11:12

diaasami mentioned this pull request Dec 2, 2021

rhel9: enable & fix ostree installer test #1744

Closed

4 tasks

distro/rhel90: enable edge-simplified-installer image type #2015

distro/rhel90: enable edge-simplified-installer image type #2015

Uh oh!

Conversation

achilleas-k commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

achilleas-k commented Nov 15, 2021

Uh oh!

henrywang commented Nov 16, 2021

Uh oh!

runcom commented Nov 16, 2021

Uh oh!

jrusz commented Nov 16, 2021

Uh oh!

achilleas-k commented Nov 16, 2021

Uh oh!

Uh oh!

Uh oh!

runcom commented Nov 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

achilleas-k commented Nov 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

runcom Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

runcom Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

runcom Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

runcom commented Nov 19, 2021

Uh oh!

achilleas-k commented Nov 19, 2021

Uh oh!

runcom commented Nov 20, 2021

Uh oh!

Uh oh!

runcom commented Nov 23, 2021

Uh oh!

achilleas-k commented Nov 23, 2021

Uh oh!

runcom commented Nov 23, 2021

Uh oh!

runcom commented Nov 24, 2021

Uh oh!

achilleas-k commented Nov 24, 2021

Uh oh!

runcom commented Nov 24, 2021

Uh oh!

achilleas-k commented Nov 25, 2021

Uh oh!

achilleas-k commented Nov 26, 2021

Uh oh!

runcom commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henrywang commented Dec 1, 2021

Uh oh!

achilleas-k commented Dec 1, 2021

Uh oh!

runcom commented Dec 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

achilleas-k commented Nov 15, 2021 •

edited

Loading

runcom commented Nov 16, 2021 •

edited

Loading

achilleas-k commented Nov 16, 2021 •

edited

Loading

runcom commented Nov 30, 2021 •

edited

Loading