New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHEL-90: Remove deprecated crashkernel=auto option
#2262
Conversation
Setting of the `crashkernel` option to the appropriate value is now done by the `kexec-tools` package when installed and when any new kernel is installed. Regenerate relevant image test cases. Fix osbuild#1819 Fix rhbz#2006692 Signed-off-by: Tomas Hozza <thozza@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @@ -9957,6 +9957,7 @@ | |||
| "/etc/pam.d/smartcard-auth": "....L....", | |||
| "/etc/pam.d/system-auth": "....L....", | |||
| "/etc/rhsm/rhsm.conf": "..5....T.", | |||
| "/etc/ssh/sshd_config": "S.5....T.", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone didn't update the test cases properly 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally me. I want a bot for this work. (-:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 Tomas at your service 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tomas! ;) I. All seriousness, this should be done by a bot instead :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I'm joking 😜
Setting of the
crashkerneloption to the appropriate value is now doneby the
kexec-toolspackage when installed and when any new kernel isinstalled.
Regenerate relevant image test cases.
Fix #1819
Fix rhbz#2006692
Signed-off-by: Tomas Hozza thozza@redhat.com
This pull request includes: