Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL-90: Remove deprecated crashkernel=auto option #2262

Merged
merged 1 commit into from Feb 7, 2022

Conversation

thozza
Copy link
Member

@thozza thozza commented Feb 4, 2022

Setting of the crashkernel option to the appropriate value is now done
by the kexec-tools package when installed and when any new kernel is
installed.

Regenerate relevant image test cases.

Fix #1819
Fix rhbz#2006692

Signed-off-by: Tomas Hozza thozza@redhat.com

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

Setting of the `crashkernel` option to the appropriate value is now done
by the `kexec-tools` package when installed and when any new kernel is
installed.

Regenerate relevant image test cases.

Fix osbuild#1819
Fix rhbz#2006692

Signed-off-by: Tomas Hozza <thozza@redhat.com>
Copy link
Contributor

@gicmo gicmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -9957,6 +9957,7 @@
"/etc/pam.d/smartcard-auth": "....L....",
"/etc/pam.d/system-auth": "....L....",
"/etc/rhsm/rhsm.conf": "..5....T.",
"/etc/ssh/sshd_config": "S.5....T.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone didn't update the test cases properly 😆

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally me. I want a bot for this work. (-:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Tomas at your service 🤣

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomas! ;) I. All seriousness, this should be done by a bot instead :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I'm joking 😜

@thozza thozza merged commit eb36b86 into osbuild:main Feb 7, 2022
@thozza thozza deleted the rhel90-crashkernel-option branch February 7, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RHEL-9] Remove deprecated option crashkernel=auto from all image definitions
3 participants