From 4f024588ec9b968ea2324f99f80c1a2e9af209f2 Mon Sep 17 00:00:00 2001
From: Max Horn <max@quendi.de>
Date: Fri, 17 Sep 2021 17:40:52 +0200
Subject: [PATCH] Remove GAP kernel function `JuliaGetFieldOfObject`

Nothing used this other than tests. And accessing a field can easily
be achieved with GAP code like this (to access `foo.bar`):

    Julia.foo.bar

Or if one *really* needs `getfield`, one can just call it:

    Julia.getfield(Julia.foo, GAPToJulia("bar"));
---
 pkg/JuliaInterface/src/JuliaInterface.c | 25 -------------------------
 pkg/JuliaInterface/tst/utils.tst        |  9 ---------
 2 files changed, 34 deletions(-)

diff --git a/pkg/JuliaInterface/src/JuliaInterface.c b/pkg/JuliaInterface/src/JuliaInterface.c
index 21009329..f4ee08c2 100644
--- a/pkg/JuliaInterface/src/JuliaInterface.c
+++ b/pkg/JuliaInterface/src/JuliaInterface.c
@@ -277,30 +277,6 @@ static Obj Func_JuliaGetGlobalVariableByModule(Obj self, Obj name, Obj module)
     return gap_julia(value);
 }
 
-// Returns the julia object GAP object that holds a pointer to the value
-// currently bound to <super_object>.<name>.
-// <super_object> must be a julia object GAP object, and <name> a string.
-static Obj FuncJuliaGetFieldOfObject(Obj self, Obj super_obj, Obj field_name)
-{
-    BEGIN_GAP_SYNC();
-    if (!IS_JULIA_OBJ(super_obj)) {
-        ErrorMayQuit(
-            "JuliaGetFieldOfObject: <super_obj> must be a Julia object", 0,
-            0);
-    }
-    RequireStringRep("JuliaGetFieldOfObject", field_name);
-
-    jl_value_t * extracted_superobj = GET_JULIA_OBJ(super_obj);
-
-    jl_value_t * field_value =
-        jl_get_field(extracted_superobj, CONST_CSTR_STRING(field_name));
-    END_GAP_SYNC();
-    if (jl_exception_occurred()) {
-        handle_jl_exception();
-    }
-    return gap_julia(field_value);
-}
-
 static Obj Func_JuliaGetGapModule(Obj self)
 {
     return NewJuliaObj((jl_value_t *)gap_module);
@@ -325,7 +301,6 @@ static StructGVarFunc GVarFuncs[] = {
     GVAR_FUNC(JuliaSetVal, 2, "name,val"),
     GVAR_FUNC(_JuliaGetGlobalVariable, 1, "name"),
     GVAR_FUNC(_JuliaGetGlobalVariableByModule, 2, "name, module"),
-    GVAR_FUNC(JuliaGetFieldOfObject, 2, "obj,name"),
     GVAR_FUNC(JuliaSymbol, 1, "name"),
     GVAR_FUNC(_JuliaGetGapModule, 0, ""),
     { 0 } /* Finish with an empty entry */
diff --git a/pkg/JuliaInterface/tst/utils.tst b/pkg/JuliaInterface/tst/utils.tst
index 5e42c972..667f0b72 100644
--- a/pkg/JuliaInterface/tst/utils.tst
+++ b/pkg/JuliaInterface/tst/utils.tst
@@ -83,15 +83,6 @@ gap> _JuliaGetGlobalVariableByModule("sqrt","Base");
 gap> _JuliaGetGlobalVariableByModule("sqrt", JuliaModule("Base"));
 <Julia: sqrt>
 
-##
-gap> JuliaGetFieldOfObject(1, "");
-Error, JuliaGetFieldOfObject: <super_obj> must be a Julia object
-gap> JuliaGetFieldOfObject(JuliaModule("Base"), fail);
-Error, JuliaGetFieldOfObject: <field_name> must be a string (not the value 'fa\
-il')
-gap> JuliaGetFieldOfObject(JuliaModule("Base"), "not-a-field");
-Error, type Module has no field not-a-field
-
 ##
 gap> NameFunction(Julia.Base.parse);
 "parse"