Refactor initialization of GAP error handling #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, we don't need to call "high-level" functions like evalstr from inside __init__, which otherwise complicates certain code refactoring. Also improve type inference for `disable_error_handler` by turning it into a `Ref`
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 82.89% 82.83% -0.06%
==========================================
Files 46 46
Lines 3618 3613 -5
==========================================
- Hits 2999 2993 -6
- Misses 619 620 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, we don't need to call "high-level" functions like evalstr
from inside init, which otherwise complicates certain code refactoring.
Also improve type inference for
disable_error_handlerby turning it into aRef