Skip to content

Loading…

erlangFun not used? #11

Open
djui opened this Issue · 13 comments

3 participants

@djui

Hej,

I can't see where erlangFun for syntax highlighting is used. In fact, all my fun declarations are as normal text. Is this intended?

@oscarh
Owner

I don't think that is intended, but I can't really remember.

What do you propose?

@djui

Well, if is the regexp was deleted by accident, you might be able to restore from git history. Otherwise writing a regexp should be rather straightforward as I saw it exists already foe the folding functionality.

@djui

I think I found the commit when erlangFun (erlangFunction?) was removed. Maybe by accident? 885c411

@djui

Ok, I guess I have a pattern now. It looks like this:

syn match erlangFun /^\%([a-z]\w*\|'\w\+'\)/
:
hi link erlangFun Function
@oscarh
Owner

Hmm, since it was on the rewrite branch, maybe I didn't care much about keeping it. Maybe the pattern was to permitting....

@djui

At least in my usage, having erlangFun is needed, otherwise I don't get any syntax highlighting for fun definitions. If you want, I can create a pull request and you can have a look at it and then merge it. Maybe I am overlooking something here, because it strikes me that nobody else complaints about this obvious missing highlighting. I have to say, I just started to use it... so "noob alert".

@oscarh
Owner

Yes please do that. If you can base your fork on my master it would be good. The integration branch isn't going nowhere fast :(

@djui

Ok, I hope I can do it tonight. Btw: Are use using something corresponding to Distel for Emacs?

@oscarh
Owner

No not really. What are you using Distel for?

@djui

Distel can do various things, among others:

  • a "better" way for looking up functions than ctags/etags
  • list all modules that call a function under the cursor
  • debug remote processes
  • open a module by just giving the module name (it will look up the location)
  • ...

In general Distel communicates with a specified erlang node that has a given code tree loaded and uses then beam information for lookups, debug, finding things.

It shouldn't be too hard to write a prototype of Distel for Vim, as a lot of functionality is actually in erlang, rather than emacs (/vim).

Are you using ctags?

@oscarh
Owner

Maybe this chat shouldn't be in the issue about erlang funs not highlighted... I'll send you a message instead :)

@geraud

Hi
Any news on this pull request?

@oscarh
Owner

Hmm, maybe I'm wrong, but I recall this being merged... Maybe it never happened though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.