[CI] Add back gitignore-test to all configurations #1971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @pwmarcz and @woju)
a discussion (no related file):
In the commit message, could you change the commit hash to commit one-liner? We still need to edit the commit history at some point to drop those binary blobs which take 700MB :/ (which will change all the hashes)
cffa975
to
2b7f076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @mkow and @woju)
a discussion (no related file):
Previously, mkow (Michał Kowalczyk) wrote…
In the commit message, could you change the commit hash to commit one-liner? We still need to edit the commit history at some point to drop those binary blobs which take 700MB :/ (which will change all the hashes)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required) (waiting on @woju)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @woju)
2b7f076
to
40dcc54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
Jenkins, retest Jenkins-Debug-18.04 please ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @pwmarcz)
a discussion (no related file):
Oops, we merged something in the meantime that gitignore-test complains about:
ERROR: Files modified by build, but not gitignored:
--------------------------------------------------------------------------------
?? LibOS/shim/test/regression/pthread_set_get_affinity
?? LibOS/shim/test/regression/sched_set_get_affinity
@pwmarcz Could you amend this PR to git-ignore these files? (Add them in LibOS/shim/test/regression/.gitignore
)
40dcc54
to
8d42e39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @dimakuv)
a discussion (no related file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Oops, we merged something in the meantime that gitignore-test complains about:
ERROR: Files modified by build, but not gitignored: -------------------------------------------------------------------------------- ?? LibOS/shim/test/regression/pthread_set_get_affinity ?? LibOS/shim/test/regression/sched_set_get_affinity
@pwmarcz Could you amend this PR to git-ignore these files? (Add them in
LibOS/shim/test/regression/.gitignore
)
Done, let's see if Jenkins passes now.
Jenkins, retest Jenkins-SGX-18.04 please ( |
Jenkins, retest Jenkins-SGX-18.04 please (poll_closed_fd LibOS test failed; IIUC, this will be fixed by Borys's #1949б second time already...) |
Removed by mistake in "[LibOS] test/ltp: Upgrade LTP to 20200930". Also add two files that have been merged without gitignore in the meantime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
8d42e39
to
5ba4708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
Removed by mistake in abe3d77.
This change is