Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an Adapter and OEmbed provider for Vimeo urls. #333

Merged
merged 1 commit into from Jan 31, 2020

Conversation

royharink
Copy link

Version 2.x doesn't have dedicated support for embedding Vimeo urls. This sometimes causes issues with particular Cloud hosting providers, like said in #326 (comment) and fixed for v3.x in #328.

This PR adds the same functionality for v2.x. Which is necessary as it's used in a popular Drupal module: https://www.drupal.org/project/url_embed.

Vimeo developer documentation:

@oscarotero oscarotero merged commit eb05178 into oscarotero:v2.x Jan 31, 2020
@oscarotero
Copy link
Owner

Thanks 👍

@stephanniewerth
Copy link

Could it be that you tagged the wrong commit?

  1. Tag name is "2.7.9" and not "v2.7.9" as usual.
  2. Commit dc1dc3c is tagged with "2.7.9" and not eb05178. dc1dc3c is the commit that is already tagged with 3.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants