Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Plans for the rails31 branch #185
Hey, I'd really like to contribute, but there's a lot of legacy code that i have some fear to touch. Does the rails31 release plan to be model-compatible to the current master? Do you want to allow upgrading through an upgrade script?
I ask this because there are a few libraries used that are either cold dead or unsupported, or not thread-safe (limiting so the available deployment options, now that heroku allows subprocesses and threads in the same dyno...).
What I'd like to see in an ideal universe:
More things in a much more ideal universe:
So, that said, what I can add depends on how much this can be changed. If you guys want to be 100% database compatible with the current version, many things can't be done, otherwise I'll be more than glad to drown you with pull requests ;)
I'd really like to see this project thrive, as I'm very interested in mass-deploying it into Barcelona time banks.
What do you think?
this is generally a good list. the goal of this project is to make it easy to adapt (in the spirit of "agile banking") and play well with others (making cucumber available to facilitate conversation with non-programmers, supporting openid 2.0, oauth 1&2, opentransact, UMA's scope format and UMA's emerging dynamic client registration spec). when the project is not meeting this goal, an issue should be created and/or the project should be forked or perhaps abandoned. :)
rails_admin offers a lot of value but as soon as it imposes a choice of one gem over a more preferred gem for important functionality, it will be removed. for instance, authentication is a very important piece of functionality for this project. this quora discussion seems to be a good analysis:
in particular, authlogic is very easy to adapt to support standards and better control over views.
model compatibility with the current master would be nice but is not a requirement. if it turns out not to be compatible, an issue should be created and it seems an upgrade script would be a good way to address such an issue.
An expectation was set in https://groups.google.com/forum/#!topic/opensourcecurrency/pOREpVgyijg that the rails31 branch would be stable by the end of August so that it can be merged into master. Until then, fixing issues labeled with high priority will have precedence over other work. @bluefibonacci has recently been doing most of the testing and issue labeling and whether an issue is high priority is up for discussion in the comments of the given issue. (i haven't reviewed the issues and priority statuses in the last day or so and a lot has changed)
the only comments i have on the ideal list is that it seems whether haml is used might be dictated by whoever steps up to drastically improve the user interface style. i like bootstrap but will wait until the time is right for that discussion.
no brainers are rails 3.2 and probably carrierwave but these are currently not high priority issues and will probably wait until after August.
auditing is desirable but needs to be optional because it quickly increases the size of the database.
related, right now, the install script deploys to the bamboo stack. it is currently not a high priority issue to change this to cedar yet.
let me know if more clarification is needed for now. executive summary: for August, if it isn't broke, it need not be fixed. merge rails31 into master by the end of the month. before this can be done, rails31 branch needs to be as stable as master and high priority issues need to be addressed.
I'd be interested in re-opening this issue (or encouraging more issues to spawn out of this one), because it seems it has been only partially implemented, and could be broken out into subtaks. We could even make it a tag! I'm excited about this.
Would love omniauth integration. We have a developer working on our project who might be interested in helping with this.
@rewritten this project looks quite promising! However, we are needing to launch something full featured fairly quickly. I would love to participate in this project in the future, however at this point we are just looking to implement bootstrap using the server side .erb templating and maybe omniauth. However, you may encounter me in the near future! Best of luck on timeoverflow.
there seems to be support for using twitter bootstrap for the UI. it also seems like it will be quite a bit of work since there is a lot of existing UI functionality. the issue came up on the 8/23 chat but there is not github issue for it: https://github.com/oscurrency/oscurrency/wiki/08-23-2012-rails31-branch-chat
i'm probably not qualified to set up "bootstrap-sass and all the other assets handling all set up" though. maybe someone else will step up to get this ball rolling.
Check the https://github.com/oscurrency/oscurrency/tree/bootstrap222 branch. I've added external bootstrap files, font-awesome, and swapped the legacy tabs with the bootstrap's ones (they weren't working).
It's based on rails329 branch.