Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build varies from date again #110

Closed
bmwiedemann opened this issue Mar 1, 2022 · 3 comments · Fixed by #117
Closed

build varies from date again #110

bmwiedemann opened this issue Mar 1, 2022 · 3 comments · Fixed by #117
Labels
bug Something that does not work as it should reproducible-builds

Comments

@bmwiedemann
Copy link

The build of osdlyrics in openSUSE had been reproducible since #34 but that changed with
b962861

One simple fix would be to add -r README.md now. Or redesign how that fallback works. See the discussion in #34 on possible approaches.

@PedroHLC
Copy link
Member

PedroHLC commented Mar 1, 2022

Maybe we could change OL_BUILD_VER to 0 unless defined by the user? Or just start using git describe --always --tags --dirty=+ in OL_VERSION with no intermediaries (and a single hardcoded fallback).

@PedroHLC PedroHLC added bug Something that does not work as it should reproducible-builds labels Apr 6, 2022
@bmwiedemann
Copy link
Author

git describe does not work in our distribution build, when we just have a release tarball.
Or you add some logic in the release workflow to add the data to the tarball and use it in there.

@PedroHLC
Copy link
Member

PedroHLC commented Jul 6, 2022

I'm working in a change in https://github.com/osdlyrics/osdlyrics/tree/configure-version-git where having a .git directory + git in PATH, will lead to git describe being used, otherwise, the hard-coded version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that does not work as it should reproducible-builds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants