Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal dialogs on Android P #1196

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Reveal dialogs on Android P #1196

merged 1 commit into from
Jan 23, 2024

Conversation

WhiredPlanck
Copy link
Collaborator

@WhiredPlanck WhiredPlanck commented Jan 23, 2024

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes # N/A

Feature

Describe features of pull request

Create a new fullscreen InputView to contain the keyboard views, just like a canvas to let all things show on it.

Code of conduct

Style lint

  • make sytle-lint

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub action ci pass
  4. At least one contributor reviews and votes
  5. Can be merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

Before

After

Create a new fullscreen InputView to contain the keyboard views, just like a canvas to let all things show on it.
@WhiredPlanck WhiredPlanck merged commit e79e32b into develop Jan 23, 2024
6 checks passed
@WhiredPlanck WhiredPlanck deleted the dialog-inputview branch February 12, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant