Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[junit5] initial #34

Merged
merged 1 commit into from
Nov 23, 2019
Merged

[junit5] initial #34

merged 1 commit into from
Nov 23, 2019

Conversation

rotty3000
Copy link
Member

Signed-off-by: Raymond Augé raymond.auge@liferay.com

@rotty3000
Copy link
Member Author

hey @bjhargrave this PR contains a profile called bnd-next which uses the latest bnd snapshot.

mvn clean install -Pbnd-next

I wonder if once this clears we could add a travis job to build this.

@rotty3000
Copy link
Member Author

btw @kriegfrj , this also contains the bnd tester.junit-platform junit5 and the peer extensions for bundle context and service use along with all the same tests we have against junit4.

@rotty3000
Copy link
Member Author

please note the junit5 tests only run when the -Pbnd-next profile is enabled.

@rotty3000 rotty3000 force-pushed the junit5.initial branch 2 times, most recently from d7b32ee to ccf01fd Compare November 16, 2019 05:27
@rotty3000
Copy link
Member Author

rotty3000 commented Nov 18, 2019 •
edited
Loading

I'd like to get this in since I think it's more or less stable. The main issues have been mostly in the junit5 test support which seems to be stabilizing in bndtools and biz.aQute.tester.junit-platform.

Actually, getting this merged will give us a platform for stabilizing that story.

@kriegfrj
Copy link
Contributor

I'll try and prioritize this tomorrow.

kriegfrj
kriegfrj requested changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@kriegfrj kriegfrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this PR looks good. However, I'm a little concerned about the degree of duplication between the junit4 and junit5 implementations (both in the implementation and the test sides). If we can sort that out we can merge. Alternatively, if you need to get this functionality in urgently, we can merge and then refactor later. I'll leave that decision to you.

org.osgi.test.common/src/main/java/org/osgi/test/common/service/ServiceAware.java Show resolved Hide resolved
org.osgi.test.common/src/main/java/org/osgi/test/common/tracking/TrackingConfig.java Show resolved Hide resolved
org.osgi.test.junit4/src/main/java/org/osgi/test/junit4/service/ServiceUseRule.java Outdated Show resolved Hide resolved
org.osgi.test.junit4/src/test/java/org/osgi/test/junit4/service/ServiceUseRuleTest.java Show resolved Hide resolved
org.osgi.test.junit5/src/test/java/org/osgi/test/junit5/ExecutorExtension.java Show resolved Hide resolved
org.osgi.test.junit5/src/test/java/org/osgi/test/junit5/service/ServiceUseExtensionTest.java Show resolved Hide resolved
@rotty3000
[junit5] initial
5dad6dd 
Signed-off-by: Raymond Augé <raymond.auge@liferay.com>
This was referenced Nov 23, 2019
Closed
Closed
@rotty3000 rotty3000 merged commit cbc1ddd into osgi:master Nov 23, 2019
@rotty3000 rotty3000 deleted the junit5.initial branch November 23, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriegfrj kriegfrj kriegfrj requested changes

@bjhargrave bjhargrave Awaiting requested review from bjhargrave

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rotty3000 @kriegfrj