strip leading and trailing, but do not squash inner whitespaces (#100) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
============================================
+ Coverage 85.81% 86.09% +0.27%
+ Complexity 255 253 -2
============================================
Files 27 27
Lines 698 683 -15
Branches 72 69 -3
============================================
- Hits 599 588 -11
+ Misses 75 73 -2
+ Partials 24 22 -2 ☔ View full report in Codecov by Sentry. |
osiegmar
reviewed
Mar 2, 2024
| return sanitizedShortMessage; | ||
| final String stripped = sanitizedShortMessage.strip(); | ||
| if (getMaxShortMessageLength() != 0 && stripped.length() > getMaxShortMessageLength()) { | ||
| return stripped.substring(0, getMaxShortMessageLength()); |
There was a problem hiding this comment.
A message a b with a max length of 5 would be returned as a . This is why I'd first only strip leading whitespaces, then do an optional substring and then the stripping of trailing whitespaces.
|
superseded by #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
Optional stripping of inner whitespaces not implemented.