Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Myplaceimport & infobox: possibility to edit fields and show images #65

Open
SannaJokela opened this issue Mar 20, 2018 · 11 comments

Comments

@SannaJokela
Copy link
Contributor

commented Mar 20, 2018

When adding own datasets through Myplaceimport, it would be convenient if one could choose if some of the attributes has image links or plain URLs. This could be either done by automated detection of URL and links ending with image format (.jpg, .png) or user could choose which attributes are links / images. Also if this would be the case, users could also choose the attributes they want to be shown in pop-up infobox.

@ZakarFin

This comment has been minimized.

Copy link
Member

commented Mar 20, 2018

That would be a nice change. The data passed to GetInfoResultEvent should be modified here to implement this for userlayers (and wfslayers in general): https://github.com/oskariorg/oskari-frontend/blob/1.45.1/bundles/mapping/mapwfs2/service/Mediator.js#L412

@SannaJokela

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2018

Any progress on this? Do we need money and some developers for this - or is it already in the production line? If not, I can help with gathering money for the production - this would greatly enhance the possibilities for e.g. association to use Oskari based services.

@ZakarFin

This comment has been minimized.

Copy link
Member

commented Apr 27, 2018

Not in the pipeline at NLS Finland for the moment at least. Not sure about other contributors.

@SannaJokela

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2018

Does this seem ok to you, if we pursue the development (just noticed that the URL links do work, but images are not detected automatically).

IMAGE LINKS TO OSKARI IN MYPLACEIMPORT TOOL & CUSTOMIZATION OF POPUP-INFO

TOOL DESCRIPTION:
Oskari has a tool for importing your own datasets (Myplaceimport) and separate tool for adding individual points, lines, areas (MyPlaces)). These two tools differ in their functionalities at the moment a little bit.

This is how the pop-up info looks like in these two different tools at the moment (screen captures from Paikkatietoikkuna.fi):

Popupinfo from user imported layers (Myplaceimport).

Popup info from individually added points (Myplaces)

Pop-up info for user imported layers is not automated and can not be customized at the moment. Currently all the information from the datasets are also shown.

When adding own datasets through Myplaceimport we want the users to be able to customise the pop-up info at least a little bit. If some of the attributes have images as links these could be shown in the popup-info like they are shown with the Myplace-tool popup.

This can be done by automated detection of URLs ending with image format (like .jpg and.png). Users should be able to choose if the image link is shown as image or not.

In this tool development the Myplaceimport datasets can be edited also in the attribute field level. Users can decide if the attribute fields are visible or not and choose if the image is also shown as image in the pop-up info tool.

Mockup

WHY TO DEVELOP THIS TOOL
The tool is considered to be good addition to current Myplaceimport tool and can be used by e.g. associations and NGOs that have the need for adding their own datasets to Oskari instances like Paikkatietoikkuna. The tool will become a core Oskari tool when developed and documented according to Oskari development procedures.

In the end normal users of Oskari instances with Myplaceimport activated, have possibility to affect how their dataset is shown through the pop-up info.

SCHEDULE:
4 days job, summer 2018.

@ZakarFin

This comment has been minimized.

Copy link
Member

commented Jun 8, 2018

4 days for implementation might be a bit tough to have a quality solution at least without prior experience of developing Oskari as there's quite a lot of things to modify when the end-user can select things. I think the attributes editor should be shown in a regular popup instead of the infobox component. Maybe just list the attributes that are in the data and have the checkboxes for show/img in a second column instead of having some random feature info shown on the edit-dialog. This selection should also affect the featuredata table (in addition to the infobox that's shown when the map is clicked). But other than that it looks ok.

@ZakarFin

This comment has been minimized.

Copy link
Member

commented Jun 8, 2018

Also since after this the end-user can modify the data that is shown... throwing in the ability to rename the attributes would be pretty straightforward to implement and would almost double the value of the feature.

@jampukka

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2018

If the data is hidden from users what's the point of storing it? Would having a possibility of deleting a column do the job? That way Featuredata tool doesn't have to be changed at all. This would also reduce the amount of data the service provider has to store.

@SannaJokela

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2018

Ok! Thank you! We will revise the plan accordingly and check the schedule (the aim is to gather money for this through co-funding and purchase the development form talented Oskari developers :) )

@SannaJokela

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2018

So if the end result would be that:

Users could

  • delete unnecessary fields

  • choose if the image is shown as image in the pop-up info tool

  • create alias-names for the field names

Should we also allow the users to

  • change the order of the fields (in which order they are shown in the pop-up info)

Is that going to be a big addition?

@ZakarFin

This comment has been minimized.

Copy link
Member

commented Jun 12, 2018

The work estimate for the ordering addition is mostly for creating the frontend for it. The order is already handled on the server based on the attribute order from the incoming data. So it's basically about updating the information that's already saved to the database. Not a large addition to the existing requirements in my opinion.

@SannaJokela SannaJokela changed the title Myplaceimport & infobox: automated detection of URL & image links Myplaceimport & infobox: possibility to edit fields and show images Jun 12, 2018

@SannaJokela

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2018

Hi again!

We are happy to launch our first ever crowdfunding case in order to enhance Oskari Myplaceimport tool, Gispo Ltd will facilitate this and Sitowise Ltd does the actual development:
In Finnish: http://www.gispo.fi/ajankohtaista/myplaceimport_oskari/
In English: http://www.gispo.fi/en/news/donate-to-oskari-myplaceimport-development/

Estimated time: if funding is received fast, the development is done in August-September 2018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.