Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar button logic #754

Merged
merged 10 commits into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@data-ux
Copy link
Contributor

commented Jan 10, 2019

The toolbar button logic has been clarified as follows:

  • Buttons declared "sticky" cannot be active with other buttons declared "sticky" (radio button style). "Sticky" is for functionalities that need to take over the whole map or otherwise set the whole UI into a different mode that allows only interactions related to that mode.
  • When a "sticky" toolbar button is selected, the current selected mode will be ended by the code implementing the functionality by using Toolbar.ToolSelectedEvent.
  • Selecting a toolbar button that is not "sticky" has no effect on the current mode. These buttons act just like any other button in the UI. For example "Save view" and "Print" buttons just open a popup/flyout, there is no mode involved.
@ZakarFin

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Looks good, but we definitely need some documentation how to handle buttons from now on so new functionalities know how to do it.

@ZakarFin ZakarFin added this to the 1.51.0 milestone Jan 24, 2019

@ZakarFin ZakarFin merged commit 58beec2 into oskariorg:develop Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.