New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this package meant to be shared with GopherJS users at large? #1

Closed
dmitshur opened this Issue Aug 22, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@dmitshur

dmitshur commented Aug 22, 2017

Hi @oskca, this looks like a nice package for the canvas part of the DOM API.

But it's not listed at https://github.com/gopherjs/gopherjs/wiki/Bindings, and some of the documentation is not English, making it hard to read for programmers who use English as a common language (not necessarily their native).

Is it your intent to make this library more generally useful and add it to the wiki page? If so, you should try to have docs be English.

If you prefer not to do that and want to keep this package for your own personal use, that's completely fine. I just wanted to ask and find out. I've found it via dominikh/go-js-dom#43 (comment).

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Jan 8, 2018

Did you see this question @oskca?

dmitshur commented Jan 8, 2018

Did you see this question @oskca?

@oskca

This comment has been minimized.

Show comment
Hide comment
@oskca

oskca Jan 9, 2018

Owner

Yeah, I'd like to do that 😄 @shurcooL

I can try the re-documenting this week

Owner

oskca commented Jan 9, 2018

Yeah, I'd like to do that 😄 @shurcooL

I can try the re-documenting this week

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Jan 9, 2018

I see, thanks for answering.

You might also find this commit interesting, dominikh/go-js-dom@6a8015d, just FYI.

dmitshur commented Jan 9, 2018

I see, thanks for answering.

You might also find this commit interesting, dominikh/go-js-dom@6a8015d, just FYI.

@oskca

This comment has been minimized.

Show comment
Hide comment
@oskca

oskca Jan 14, 2018

Owner

I've done the re doc 😄

Owner

oskca commented Jan 14, 2018

I've done the re doc 😄

@oskca oskca closed this Jan 14, 2018

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Jan 16, 2018

Great!

In case you missed it, I'll point to this again:

You might also find this commit interesting, dominikh/go-js-dom@6a8015d, just FYI.

If you don't want to apply the entire change, a minimal version to consider would be changing from using color.RGBA to color.NRGBA.

dmitshur commented Jan 16, 2018

Great!

In case you missed it, I'll point to this again:

You might also find this commit interesting, dominikh/go-js-dom@6a8015d, just FYI.

If you don't want to apply the entire change, a minimal version to consider would be changing from using color.RGBA to color.NRGBA.

@oskca

This comment has been minimized.

Show comment
Hide comment
@oskca

oskca Jan 17, 2018

Owner

@shurcooL hi, i've done the converting from color.RGBA to color.NRGBA
When I was doing this wrapper library, gopherjs would produce huge output, so I tried to import as less library as possible(especially dominikh/go-js-dom which would increase the output js file size), so I wrap a little library to do the dom manipulation.

When I have time, perhaps I'll recheck the situation to use dominikh/go-js-dom instead. 😄

Owner

oskca commented Jan 17, 2018

@shurcooL hi, i've done the converting from color.RGBA to color.NRGBA
When I was doing this wrapper library, gopherjs would produce huge output, so I tried to import as less library as possible(especially dominikh/go-js-dom which would increase the output js file size), so I wrap a little library to do the dom manipulation.

When I have time, perhaps I'll recheck the situation to use dominikh/go-js-dom instead. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment