From f325765f0d23e9ff8dfa973bd828ab23cb1f67b9 Mon Sep 17 00:00:00 2001 From: Ondrej Skopek Date: Tue, 9 Sep 2014 02:04:36 +0200 Subject: [PATCH 1/2] Change null to "null" (type string) to prevent NPE in Guava's ImmutableMap --- .../org/carcv/impl/core/detect/NumberPlateDetectorImpl.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/carcv-core/src/main/java/org/carcv/impl/core/detect/NumberPlateDetectorImpl.java b/carcv-core/src/main/java/org/carcv/impl/core/detect/NumberPlateDetectorImpl.java index 2baba18..287f2b5 100644 --- a/carcv-core/src/main/java/org/carcv/impl/core/detect/NumberPlateDetectorImpl.java +++ b/carcv-core/src/main/java/org/carcv/impl/core/detect/NumberPlateDetectorImpl.java @@ -73,7 +73,11 @@ public String detect(final List images) { public String detectPlateText(final List images) { ArrayList numberPlates = new ArrayList<>(); for (AbstractCarImage image : images) { - numberPlates.add(intel.recognize(new CarSnapshot(image.getImage()))); + String plate = intel.recognize(new CarSnapshot(image.getImage())); + if (plate == null) { + plate = "null"; + } + numberPlates.add(plate); } return CollectionUtils.highestCountElement(numberPlates); } From fcf3a4b28768567d2fcdb747318d589c83d60345 Mon Sep 17 00:00:00 2001 From: Ondrej Skopek Date: Tue, 9 Sep 2014 02:14:51 +0200 Subject: [PATCH 2/2] Added logger warning --- .../org/carcv/impl/core/detect/NumberPlateDetectorImpl.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/carcv-core/src/main/java/org/carcv/impl/core/detect/NumberPlateDetectorImpl.java b/carcv-core/src/main/java/org/carcv/impl/core/detect/NumberPlateDetectorImpl.java index 287f2b5..d91fadf 100644 --- a/carcv-core/src/main/java/org/carcv/impl/core/detect/NumberPlateDetectorImpl.java +++ b/carcv-core/src/main/java/org/carcv/impl/core/detect/NumberPlateDetectorImpl.java @@ -28,6 +28,8 @@ import org.carcv.core.detect.NumberPlateDetector; import org.carcv.core.model.AbstractCarImage; import org.carcv.impl.core.util.CollectionUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.xml.sax.SAXException; /** @@ -39,6 +41,8 @@ */ public class NumberPlateDetectorImpl extends NumberPlateDetector { + final private static Logger LOGGER = LoggerFactory.getLogger(NumberPlateDetectorImpl.class); + private static NumberPlateDetectorImpl detector; private Intelligence intel; @@ -76,6 +80,7 @@ public String detectPlateText(final List images) { String plate = intel.recognize(new CarSnapshot(image.getImage())); if (plate == null) { plate = "null"; + LOGGER.warn("Plate on image ID {} wasn't detected, writing null.", image.getId()); } numberPlates.add(plate); }