Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add update check functionality #158

Closed
anilgulecha opened this Issue · 5 comments

2 participants

@anilgulecha

As all modern programs, Trelby can check (at max) once in a while for newer version. I'd guess a majority of our users do not subscribe to twitter/site rss, and this would be a nice way to let them know of an update being available.

http://www.trelby.org/releases/version can be:

2.2
http://www.trelby.org/releases/2.2/trelby-2.2.exe

This file can be periodically checked against installed version (which we update every release). The first line is the version, and the second the download location, to be opened in a browser.

@oskusalerma
Owner

The idea is fine, the implementation you suggest is flawed.

  • Link just to the windows version? What about Linux users? What about possible future mac users?
  • We cannot simply tell the user to upgrade, the user has to make that decision, after reading the change descriptions and deciding he's fine with them. We will drop support for older platforms and do other breaking changes in the future; a program that tells the user to auto-upgrade and then stops working is a broken program.
  • It should simply check once in a while if a new version is available, and if so, direct the user to the changes page.
  • The "check if new version is available" must be coded carefully so it never blocks the program from starting up or delays it, even if the user has no internet connection, there are DNS problems, or whatever.
@anilgulecha

Ah right. The second line can simply be http://www.trelby.org/download (or changes), which will be opened in the browser if there is a newer version found. It's upto the user to download this if wanted.

@anilgulecha

Osku: how about using wx.DelayedResult for this?

http://wxpython.org/docs/api/wx.lib.delayedresult-module.html

It takes care of creating a thread etc.. so we don't have to deal with it, and seems to work well in the wxpython demo.

@oskusalerma
Owner

If it works that simply, sure, and whoever implements it makes sure to test it will never cause any problems in the running of the program, no matter what (internet down, the code has a bug and throws an exception, etc etc).

@oskusalerma
Owner

If somebody implements this, great, but not worth keeping an issue open.

@oskusalerma oskusalerma closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.