Type complexity algorithm #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for every type of node
…h handling the nuance of a different AST node.
shalarewicz
reviewed
Jun 3, 2022
shalarewicz
reviewed
Jun 4, 2022
| } | ||
|
|
||
| /** | ||
| * There are numorous ways to get the ip address off of the request object. |
Collaborator
There was a problem hiding this comment.
Great catch on this. This came up while writing tests but I never created an issue for it. It will be a good post mvp discussion. Created #47
shalarewicz
approved these changes
Jun 4, 2022
Collaborator
shalarewicz
left a comment
shalarewicz
left a comment
There was a problem hiding this comment.
Really great work and gives us solid groundwork for expanding.
Revsoled weight function conflict in complexity algo
Collaborator
|
Updated evidence. All tests still passing |
milos381
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a functioning type complexity analysis algorithm that passes tests up to and including
with aliases. The algorithm traverses the query AST which is a bunch of nested nodes of different graphQL types. The algorithm implements a different function for each AST Node Type so that the algorithm is modular and easily extendable. To add new functionality, create a new function to handle the GraphQL Node that holds the responsibility for that functionality.Still to do
Type of Change
Issues
Evidence